Skip to content

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Mar 6, 2025

Make sure it's running, using TLS if enabled and that the IPA ramdisk
gets downloaded there (or not, when the downloader is disabled).

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@metal3-io-bot metal3-io-bot requested review from Rozzii and tuminoid March 6, 2025 15:58
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2025
@dtantsur dtantsur force-pushed the test-httpd branch 5 times, most recently from 8ec85e7 to b67294e Compare March 7, 2025 14:23
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion added.

Make sure it's running, using TLS if enabled and that the IPA ramdisk
gets downloaded there (or not, when the downloader is disabled).

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@dtantsur
Copy link
Member Author

/cc @elfosardo

@metal3-io-bot metal3-io-bot requested a review from elfosardo March 11, 2025 09:26
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2025
@metal3-io-bot metal3-io-bot merged commit 7de64f7 into metal3-io:main Mar 11, 2025
13 of 14 checks passed
@dtantsur dtantsur deleted the test-httpd branch March 11, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants