⚠️ Disallow downgrades when an external database is used #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtantsur
changed the title
metal3-io-bot
added
the
size/L
dtantsur
force-pushed
the
no-downgrade
branch
3 times, most recently
from
6fa465f to
12d89bd
Compare
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
|
/hold cancel Rebased |
metal3-io-bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Ironic does not support downgrades, its dbsync script will fail. Make exception for going from latest to a numeric version. The expected scenario is a user following latest for some time, then deciding to settle on a specific version once everything they need is available. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
|
Needs rebase? |
Not really, seems to be fresh? |
That was reference to the golangci-lint issue we had. I thought it failed due the linter cleanup PR/version mismatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ironic does not support downgrades, its dbsync script will fail.
Make exception for going from latest to a numeric version. The expected
scenario is a user following latest for some time, then deciding to
settle on a specific version once everything they need is available.
Depends on:
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com