Skip to content

🌱 Use a multi-node cluster in functional tests #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

🌱 Use a multi-node cluster in functional tests #195

merged 2 commits into from
Apr 14, 2025

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Mar 26, 2025 •
edited
Loading

This PR enables real HA testing on a multi-node minikube cluster.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2025
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2025
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2025
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2025
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2025
@dtantsur dtantsur marked this pull request as draft April 3, 2025 14:27
@dtantsur dtantsur force-pushed the multinode branch 3 times, most recently from 402b396 to cb16593 Compare April 4, 2025 11:51
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2025
@dtantsur dtantsur mentioned this pull request Apr 4, 2025
Open
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 4, 2025
@dtantsur dtantsur force-pushed the multinode branch 2 times, most recently from 98bd9b1 to 45e5980 Compare April 4, 2025 15:15
@dtantsur dtantsur changed the title WIP multi-node functional tests 🌱 Use a multi-node cluster in functional tests Apr 5, 2025
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2025
@dtantsur dtantsur marked this pull request as draft April 5, 2025 18:34
@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2025
@dtantsur dtantsur added this to the IrSO - v0.4 milestone Apr 8, 2025
@dtantsur dtantsur force-pushed the multinode branch 2 times, most recently from 2023968 to cf39a49 Compare April 10, 2025 11:49
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2025
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2025
@dtantsur dtantsur marked this pull request as ready for review April 11, 2025 11:59
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025
lentzi90
lentzi90 reviewed Apr 14, 2025
View reviewed changes
dtantsur added 2 commits April 14, 2025 12:41
@dtantsur
Run the functional job on a multi-node minikube cluster
88bcf45 
This allows us to test the real HA scenario (the tests themselves
already exist but so far has been testing a "single-node HA").

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Increase the overall functional tests timeout
4269568 
With the multinode testing, we're getting close to 60m.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur dtantsur requested a review from lentzi90 April 14, 2025 10:44
lentzi90
lentzi90 reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@metal3-io-bot metal3-io-bot merged commit 782bbe7 into metal3-io:main Apr 14, 2025
13 checks passed
@dtantsur dtantsur deleted the multinode branch April 14, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid Awaiting requested review from tuminoid

@elfosardo elfosardo Awaiting requested review from elfosardo

@Rozzii Rozzii Awaiting requested review from Rozzii

1 more reviewer

@lentzi90 lentzi90 lentzi90 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
IrSO - v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@dtantsur @metal3-io-bot @elfosardo @lentzi90