Skip to content

🌱 Enable godot and perfsprint linters #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

🌱 Enable godot and perfsprint linters #216

merged 1 commit into from
Apr 2, 2025

Conversation

alexal
Copy link
Contributor

@alexal alexal commented Mar 28, 2025 •
edited
Loading

  • Enabled the following linters in .golangci.yaml:
    • godot
    • perfsprint

Fixes #201
Fixes #206

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 28, 2025
@metal3-io-bot
Copy link
Contributor

Hi @alexal. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 28, 2025
@alexal alexal changed the title Enable additional linters Patch fix: Enable additional linters Mar 28, 2025
@alexal alexal changed the title Patch fix: Enable additional linters 🌱 Enable additional linters Mar 28, 2025
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2025
tuminoid
tuminoid reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alexal !

Please address rest of the linter failures. It seems many of the newly enabled linters still fail in api and test modules. You can run make lint locally to iterate.

/retitle 🌱 Enable godot, mnd, perfsprint and tagliatelle linters

@metal3-io-bot metal3-io-bot changed the title 🌱 Enable additional linters 🌱 Enable godot, mnd, perfsprint and tagliatelle linters Mar 28, 2025
dtantsur
dtantsur reviewed Mar 28, 2025
View reviewed changes
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2025
@alexal alexal requested review from dtantsur and tuminoid March 28, 2025 12:43
@alexal
Copy link
Contributor Author

alexal commented Mar 28, 2025

@dtantsur, @tuminoid done, please review the changes again.

tuminoid
tuminoid reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 28, 2025
@alexal alexal requested a review from tuminoid March 31, 2025 13:56
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur reviewed Mar 31, 2025
View reviewed changes
dtantsur
dtantsur previously requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking up this work! I quite vehemently disagree with some of the changes here. I think all of them come from mnd, maybe we shouldn't enable it in the end. See inline.

@alexal alexal changed the title 🌱 Enable godot, mnd, perfsprint and tagliatelle linters 🌱 Enable godot, mnd and perfsprint linters Mar 31, 2025
@alexal alexal changed the title 🌱 Enable godot, mnd and perfsprint linters 🌱 Enable godot and perfsprint linters Mar 31, 2025
@alexal alexal requested a review from dtantsur March 31, 2025 15:57
@alexal
Copy link
Contributor Author

alexal commented Mar 31, 2025

Thank you for picking up this work! I quite vehemently disagree with some of the changes here. I think all of them come from mnd, maybe we shouldn't enable it in the end. See inline.

Sure, please see the updated changes.

@dtantsur
Copy link
Member

dtantsur commented Apr 1, 2025

/approve

Thanks. This PR needs a rebase though.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 1, 2025
@alexal
Copy link
Contributor Author

alexal commented Apr 1, 2025 •
edited
Loading

@dtantsur

Thanks. This PR needs a rebase though.

Done

@tuminoid
Copy link
Member

tuminoid commented Apr 1, 2025

Squash the commit please, then its LGTM.

@alexal
🌱 Enable godot and perfsprint linters
06d73d8 
Signed-off-by: Alex Rodin <alexander.a.rodin@gmail.com>
@alexal
Copy link
Contributor Author

alexal commented Apr 1, 2025

@tuminoid

Squash the commit please, then its LGTM.

Done.

@tuminoid tuminoid dismissed dtantsur’s stale review April 2, 2025 05:01

Has approved

tuminoid
tuminoid reviewed Apr 2, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for the contribution!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
@metal3-io-bot metal3-io-bot merged commit b994794 into metal3-io:main Apr 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable "perfsprint" linter in golangci-lint Enable "godot" linter in golangci-lint
4 participants
@alexal @metal3-io-bot @tuminoid @dtantsur