Skip to content

🌱 switch to new cncf oracle gh runners #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 switch to new cncf oracle gh runners #318

wants to merge 1 commit into from

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Aug 7, 2025 •
edited
Loading

See BMO 2599 for reference.

/hold
To be merged when all repos show green with new workers.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2025
@tuminoid
Copy link
Member Author

tuminoid commented Aug 7, 2025

Job is queued as this repo needs to be whitelisted to use the new workers on metal3-io org-level, will fix that soon.

@tuminoid
Copy link
Member Author

tuminoid commented Aug 7, 2025

/retest

1 similar comment
@tuminoid
Copy link
Member Author

tuminoid commented Aug 7, 2025

/retest

@lentzi90
Copy link
Member

lentzi90 commented Aug 7, 2025

Looks like we have an issue here
/cc @dtantsur

@metal3-io-bot metal3-io-bot requested a review from dtantsur August 7, 2025 07:19
@tuminoid
Copy link
Member Author

tuminoid commented Aug 7, 2025

/retest

5 similar comments
@tuminoid
Copy link
Member Author

tuminoid commented Aug 8, 2025

/retest

@tuminoid
Copy link
Member Author

tuminoid commented Aug 8, 2025

/retest

@tuminoid
Copy link
Member Author

tuminoid commented Aug 8, 2025

/retest

@tuminoid
Copy link
Member Author

tuminoid commented Aug 8, 2025

/retest

@tuminoid
Copy link
Member Author

tuminoid commented Aug 8, 2025

/retest

lentzi90
lentzi90 reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2025
@tuminoid
Copy link
Member Author

tuminoid commented Aug 8, 2025

/retest

2 similar comments
@tuminoid
Copy link
Member Author

tuminoid commented Aug 8, 2025

/retest

@tuminoid
Copy link
Member Author

tuminoid commented Aug 8, 2025

/retest

@tuminoid tuminoid force-pushed the tuomo/update-to-cncf-new-runners branch from 79cbe4c to 2c5a3b0 Compare August 11, 2025 04:46
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
@tuminoid
Copy link
Member Author

Trying larger variant, 4cpu/16gb went thru on only on 10th try. Trying 8cpu/32gb now.

@tuminoid
Copy link
Member Author

/retest

2 similar comments
@tuminoid
Copy link
Member Author

/retest

@tuminoid
Copy link
Member Author

/retest

@tuminoid
Copy link
Member Author

OK, dunno if its just luck or not, but on larger runner it passed on 3rd, vs on 10th.

@tuminoid tuminoid force-pushed the tuomo/update-to-cncf-new-runners branch from 2c5a3b0 to b4c4a30 Compare August 12, 2025 05:33
@tuminoid
Copy link
Member Author

Moved to back to 4cpu/16gb testing after HA timeout fix was merged in main to see if it helps.

@tuminoid tuminoid force-pushed the tuomo/update-to-cncf-new-runners branch from b4c4a30 to f2d6eb1 Compare August 12, 2025 07:21
@tuminoid
Copy link
Member Author

[FAIL] Ironic object tests [It] creates Ironic with provided credentials [api-secret]

/retest

lentzi90
lentzi90 reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
@Rozzii
Copy link
Member

Rozzii commented Aug 13, 2025

/retest

@Rozzii Rozzii mentioned this pull request Aug 13, 2025
Merged
@tuminoid
Copy link
Member Author

[FAIL] Ironic object tests [It] creates Ironic with TLS [tls]

/retest

@tuminoid
Copy link
Member Author

[FAIL] Ironic object tests [It] creates Ironic 29.0 with HA and upgrades to 30.0 [ha-v290-to-300, ha, upgrade]

/retest

@tuminoid
Copy link
Member Author

OK, with smaller instance it passed on 6th try now. So getting it to go thru on larger instance on 3rd was probably just lucky.

This 16% success rate (or lower in reality) is still far below how it performs now, so it still needs to be investigated.

@tuminoid tuminoid force-pushed the tuomo/update-to-cncf-new-runners branch from f2d6eb1 to cedd7ef Compare August 18, 2025 13:01
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025
@tuminoid
Copy link
Member Author

Rebased to get latest fixes and more runs/logs.

@tuminoid
Copy link
Member Author

Wow, passed on 1st try so 2 in a row now....

Rozzii
Rozzii reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@tuminoid
Copy link
Member Author

/retest

@tuminoid
Copy link
Member Author

/retest
New runners are now Intel based.

@tuminoid
Copy link
Member Author

/retest
AMD E5 + faster storage enabled.

@tuminoid
Copy link
Member Author 

[FAIL] Ironic object tests [It] creates Ironic 29.0 and upgrades to 30.0 [v290-to-300, upgrade]

/retest

@tuminoid
Copy link
Member Author 

  [FAIL] Ironic object tests [It] creates Ironic 28.0 with HA and upgrades to 29.0 [ha-v280-to-v290, ha, upgrade]
  /home/ubuntu/_work/ironic-standalone-operator/ironic-standalone-operator/test/suite_test.go:227
  [FAIL] Ironic object tests [It] creates Ironic 31.0 with HA and upgrades to latest [ha-v310-to-latest, ha, upgrade]
  /home/ubuntu/_work/ironic-standalone-operator/ironic-standalone-operator/test/suite_test.go:267

@tuminoid
switch to new cncf oracle gh runners
a1fd495 
Switch to new cncf oracle GH runners.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/update-to-cncf-new-runners branch from cedd7ef to a1fd495 Compare August 21, 2025 05:51
@metal3-io-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@tuminoid
Copy link
Member Author

Rebased to IRSO main, which has now a fix for regression from upstream Ironic. Main should be stable now, so any failures are most likely from runner change again.

@tuminoid
Copy link
Member Author

/retest

@tuminoid
Copy link
Member Author 

  [FAIL] Ironic object tests [It] creates Ironic 30.0 with HA and upgrades to 31.0 [ha-v300-to-310, ha, upgrade]
  /home/ubuntu/_work/ironic-standalone-operator/ironic-standalone-operator/test/suite_test.go:227
  [FAIL] Ironic object tests [It] creates Ironic 31.0 with HA and upgrades to latest [ha-v310-to-latest, ha, upgrade]
  /home/ubuntu/_work/ironic-standalone-operator/ironic-standalone-operator/test/suite_test.go:227
  [FAIL] Ironic object tests [It] creates highly available Ironic with TLS and credentials [ha-tls-api-secret, ha]
  /home/ubuntu/_work/ironic-standalone-operator/ironic-standalone-operator/test/suite_test.go:227

/retest

@tuminoid
Copy link
Member Author 

 [FAIL] Ironic object tests [It] creates Ironic 27.0 and upgrades to 28.0 [v270-to-280, upgrade]

/retest

@tuminoid
Copy link
Member Author 

  [FAIL] Ironic object tests [It] creates Ironic 30.0 and upgrades to 31.0 [v300-to-310, upgrade]

/retest

@tuminoid
Copy link
Member Author 

FAIL] Ironic object tests [It] refuses to downgrade Ironic with a database [no-db-downgrade, upgrade]

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

+1 more reviewer

@lentzi90 lentzi90 lentzi90 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @lentzi90 @Rozzii