🌱 Add wf to automatically build controller image #50
Conversation
metal3-io-bot
added
the
size/S
| - 'v*' | ||
|
|
||
| jobs: | ||
| build_controller: |
There was a problem hiding this comment.
Are we expecting to have many jobs here? If not, then I'd probably not use controller in naming, but operator, or ISO (like IPAM) as more descriptive.
There was a problem hiding this comment.
I think there might be more images coming, based on what I found on the Makefile. IMO operator is not more descriptive though, ISO might be, but it's not yet a familiar acronym yet, at least for me. controller is, therefore, more suitable, as anyone could understand what it builds from the name. This is anyway just the name of the job, not the image name.
| if: github.repository == 'metal3-io/ironic-standalone-operator' | ||
| uses: metal3-io/project-infra/.github/workflows/container-image-build.yml@main | ||
| with: | ||
| image-name: 'ironic-standalone-operator/controller' |
There was a problem hiding this comment.
Same here, and I'm not even sure we actually want to have it named like that, but just ironic-standalone-operator or even ironic-standalone-operator-controller.
There was a problem hiding this comment.
I was following the naming convention in Makefile. Afaik there's at least bundle image, although the Dockerfile for it is nowhere to be found. But I agree ironic-standalone-operator-controller would be a good name.
@dtantsur Wdyt?
There was a problem hiding this comment.
Makefile is basically auto-generated. I'd definitely use just ironic-standalone-operator to be consistent with baremetal-operator.
There was a problem hiding this comment.
Sorry I missed the comment. Change coming up!
|
@dtantsur you asked for workflow to build the images, would you mind taking a look and weighting in on job naming? |
Signed-off-by: Huy Mai <huy.mai@est.tech>
mquhuy
force-pushed
the
mquhuy/add-automatic-controller-image-build
branch
from
963d681 to
94746ad
Compare
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
This PR adds support for automatic container image build. Whenever a new PR is merged into
mainor one of the release branches, and whenever a newv*tag is created, a new container image is built and pushed toquay.io/metal3-io, with suitable tags applied.