Skip to content

Conversation

iurygregory
Copy link
Member

@iurygregory iurygregory commented Oct 29, 2024

Closes: #52

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2024
@iurygregory
Copy link
Member Author

Seems like CI uses 1.22.8 .-.

And I only noticed now the comment in the issue:
NOTE: do not bump go.mod versions for the sake of bumping. They shall be bumped only if language features using Go 1.23 are used in code, or by dependencies force it.
🤔 So I will think a bit on how to proceed , since this was what I did.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a Go dependency bump, rather than Golang bump that we're after in #52.

TBH, you could just remove the go directive bumps here, and retitle it, and its 100% valid k8s/controller-runtime bump PR as is, which is also needed. I suggest we go this route and make another PR for golang bump.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
@iurygregory iurygregory changed the title Update go to 1.23 bump golang to 1.23.2 Oct 29, 2024
@iurygregory iurygregory requested a review from tuminoid October 29, 2024 12:29
@tuminoid
Copy link
Member

Yup, this fulfills the minimum requirements for a bump.

Did you check the release notes for any changes that could be utilized here, or changes in behavior that needs to be considered?

@iurygregory
Copy link
Member Author

Yup, this fulfills the minimum requirements for a bump.

Did you check the release notes for any changes that could be utilized here, or changes in behavior that needs to be considered?

I've checked https://tip.golang.org/doc/go1.23 , the only thing that caught my eyes was the Timer changes , but it shouldn't be a big impact for us.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is language specific changes needed or wanted to be utilized, then
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@metal3-io-bot metal3-io-bot merged commit 103a594 into metal3-io:main Oct 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Golang to 1.23
4 participants