-
Notifications
You must be signed in to change notification settings - Fork 12
bump golang to 1.23.2 #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems like CI uses 1.22.8 .-. And I only noticed now the comment in the issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a Go dependency bump, rather than Golang bump that we're after in #52.
TBH, you could just remove the go directive bumps here, and retitle it, and its 100% valid k8s/controller-runtime bump PR as is, which is also needed. I suggest we go this route and make another PR for golang bump.
Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
Yup, this fulfills the minimum requirements for a bump. Did you check the release notes for any changes that could be utilized here, or changes in behavior that needs to be considered? |
I've checked https://tip.golang.org/doc/go1.23 , the only thing that caught my eyes was the Timer changes , but it shouldn't be a big impact for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is language specific changes needed or wanted to be utilized, then
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: #52