-
Notifications
You must be signed in to change notification settings - Fork 127
Add support for openSUSE Leap 15.6 #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d501a33
to
1bfb9b9
Compare
- Install required packages using 01 script and ansible - Add suse specific configuration to ansible - Expand network configurations to support also suse - Specify python interpreter for ansible playbook for tests - Add templates to provision suse based images - Add suse specific cleanup - Supports kind and minikube Signed-off-by: Nuutti Hakala <nuutti.hakala@est.tech>
1bfb9b9
to
9ea51c3
Compare
Minikube runs ironic inside a kubernetes pod, so it requires the ironic endpoint to be present only inside the VM. Ironic runs on the host with kind, so it requires the ironicendpoint interface to be present on the host. Furthermore, keepalived requires that the ironicendpoint interface has at least one IP-address assigned. Hence we have effectively two different network setups and I separated those into different functions to make it more readable. I also believe that with this configuration we could make kind work also on centos, because the interface creation stuff should not be distro specific. Another thing is that the kind network configuration is doing more or less the same thing as first half of One thing is that how do we want to write the configuration? Do we want to explicitly write the configuration for different distros with if clauses or do we want to make the configuration depend on the used kubernetes provider? tldr: should I refactor the networking setup even further or should I revert it and make some specific case only for suse? |
/hold |
Just to reflect on the manpower issue, we are willing to maintain it and integrate it to the CI, work is already ongoing. I 100% agree that we have to discuss this with the community but AFAIK there won't be any negative side effect for the already supported distros and we are not aiming to design any SLES/LEAP specific use cases. This dev-env support does not come with the requirement to build openSUSE based Ironic images either, we would just like to upstream code to dev-env to allow folks run dev-env on openSUSE. |
I think manpower and maintaining CI jobs wont be an issue as we are willing to maintain it along with other CI jobs as well. |
my comment comes mainly from observation of the latest year and a half advancement in CI |
I think this is pretty orthogonal to the Ubuntu or CentOS work, but sure lets discuss in the upcoming community meeting so that we are on the same page. |
This PR adds support for openSUSE Leap 15.6. It supports both kind and minikube.