Change interface name after enabling predicted interface names #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
metal3-io-bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/S
Sunnatillo
force-pushed
the
Sunnatillo/fix-interface-name-vrrp
branch
from
feec983 to
116ac5a
Compare
metal3-io-bot
added
size/XS
Sunnatillo
force-pushed
the
Sunnatillo/fix-interface-name-vrrp
branch
from
116ac5a to
335a12a
Compare
|
/test metal3-centos-e2e-integration-test-main |
Sunnatillo
force-pushed
the
Sunnatillo/fix-interface-name-vrrp
branch
2 times, most recently
from
45b67e9 to
f5b3b1f
Compare
metal3-io-bot
added
size/S
Sunnatillo
force-pushed
the
Sunnatillo/fix-interface-name-vrrp
branch
2 times, most recently
from
19a6fd7 to
71733a2
Compare
metal3-io-bot
added
size/L
Sunnatillo
force-pushed
the
Sunnatillo/fix-interface-name-vrrp
branch
from
71733a2 to
3934126
Compare
Sunnatillo
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
|
Can you document in the PR description what is the value of this change? |
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
Sunnatillo
force-pushed
the
Sunnatillo/fix-interface-name-vrrp
branch
from
3934126 to
e34124a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to interface names after enabling predictable interface names in node images.
We have build centos node images with kernel parameter "net.ifnames=0", as a result we had interface names eth0, eth1 on centos nodes.
On project infra PR we are changing this parameters "net.ifnames=1". Now interface names will be predicted. Stable names based on hardware information. enp1s0, eno1.