Skip to content

update releasing process doc #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

update releasing process doc #550

merged 1 commit into from
Jun 17, 2025

Conversation

tuminoid
Copy link
Member

Update prior art, remove mariadb references, add IrSO parts, remove TODO etc.

@metal3-io-bot metal3-io-bot requested review from lentzi90 and Rozzii June 13, 2025 07:19
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2025
@tuminoid
Copy link
Member Author

It fails until metal3-io/ironic-standalone-operator#211 is merged.

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2025
@tuminoid tuminoid mentioned this pull request Jun 13, 2025
Merged
@tuminoid
Copy link
Member Author

/cc @elfosardo @dtantsur @lentzi90 @Rozzii

PTAL if I missed something. We have to invent keepalived etc releasing and then document that too, but that is separate update.

dtantsur
dtantsur reviewed Jun 13, 2025
View reviewed changes
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2025
@tuminoid tuminoid force-pushed the tuomo/update-releasing-doc branch from 2d2af77 to 584a73b Compare June 13, 2025 13:24
lentzi90
lentzi90 reviewed Jun 16, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
Rozzii
Rozzii reviewed Jun 16, 2025
View reviewed changes
@Rozzii
Copy link
Member

Rozzii commented Jun 16, 2025

/hold
Feel free to remove the hold after my comment was addressed. #550 (comment)

@tuminoid tuminoid force-pushed the tuomo/update-releasing-doc branch from 584a73b to ffc93d3 Compare June 16, 2025 12:43
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
@tuminoid
Copy link
Member Author

/unhold
/cc @Rozzii @lentzi90

@metal3-io-bot metal3-io-bot requested review from lentzi90 and Rozzii June 16, 2025 12:44
@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2025
@tuminoid
update releasing process doc
221d8ba 
Update prior art, add IrSO parts, remove TODO etc.

Mariadb tagging is deprecated and will apply the CAPM3 v1.11 and not
releases after that.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/update-releasing-doc branch from ffc93d3 to 221d8ba Compare June 16, 2025 12:51
lentzi90
lentzi90 reviewed Jun 16, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
@tuminoid
Copy link
Member Author

Retest to get link check to pass after IRSO document PR is merged.

Rozzii
Rozzii reviewed Jun 16, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@tuminoid
Copy link
Member Author

/retest
/unhold

@tuminoid
Copy link
Member Author

Duh too many requests. Let's try tomorrow again.

@tuminoid
Copy link
Member Author

/retest

@metal3-io-bot metal3-io-bot merged commit b121d0a into metal3-io:main Jun 17, 2025
9 of 13 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/update-releasing-doc branch June 17, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@Rozzii Rozzii Rozzii left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

+1 more reviewer

@lentzi90 lentzi90 lentzi90 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @dtantsur @metal3-io-bot @Rozzii @lentzi90