Skip to content

Fix running minikube on ubuntu #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix running minikube on ubuntu #1055

wants to merge 1 commit into from

Conversation

Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Jul 3, 2025 •
edited
Loading

@Sunnatillo
Fix running minikube on ubuntu
8527b3d 
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
@metal3-io-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Sunnatillo Sunnatillo marked this pull request as ready for review July 3, 2025 12:30
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2025
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 3, 2025
@Sunnatillo
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: The following commands are available to trigger required jobs:

/test check-prow-config

/test markdownlint

/test metal3-ubuntu-e2e-integration-test-main

/test shellcheck

/test spellcheck

The following commands are available to trigger optional jobs:

/test metal3-bml-integration-test-centos

/test metal3-centos-e2e-basic-test-main

/test metal3-centos-e2e-basic-test-release-1-10

/test metal3-centos-e2e-basic-test-release-1-8

/test metal3-centos-e2e-basic-test-release-1-9

/test metal3-centos-e2e-capi-md-test-main

/test metal3-centos-e2e-feature-test-main-features

/test metal3-centos-e2e-feature-test-main-pivoting

/test metal3-centos-e2e-feature-test-main-remediation

/test metal3-centos-e2e-feature-test-release-1-10-features

/test metal3-centos-e2e-feature-test-release-1-10-pivoting

/test metal3-centos-e2e-feature-test-release-1-10-remediation

/test metal3-centos-e2e-feature-test-release-1-8-features

/test metal3-centos-e2e-feature-test-release-1-8-pivoting

/test metal3-centos-e2e-feature-test-release-1-8-remediation

/test metal3-centos-e2e-feature-test-release-1-9-features

/test metal3-centos-e2e-feature-test-release-1-9-pivoting

/test metal3-centos-e2e-feature-test-release-1-9-remediation

/test metal3-centos-e2e-integration-test-main

/test metal3-centos-e2e-integration-test-release-1-10

/test metal3-centos-e2e-integration-test-release-1-8

/test metal3-centos-e2e-integration-test-release-1-9

/test metal3-ci-image-building

/test metal3-dev-env-integration-test-centos-main

/test metal3-dev-env-integration-test-centos-release-1-10

/test metal3-dev-env-integration-test-centos-release-1-8

/test metal3-dev-env-integration-test-centos-release-1-9

/test metal3-dev-env-integration-test-ubuntu-main

/test metal3-dev-env-integration-test-ubuntu-release-1-10

/test metal3-dev-env-integration-test-ubuntu-release-1-8

/test metal3-dev-env-integration-test-ubuntu-release-1-9

/test metal3-e2e-1-29-1-30-upgrade-test-main

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-10

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-8

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-9

/test metal3-e2e-clusterctl-upgrade-test-main

/test metal3-e2e-clusterctl-upgrade-test-release-1-10

/test metal3-e2e-clusterctl-upgrade-test-release-1-8

/test metal3-e2e-clusterctl-upgrade-test-release-1-9

/test metal3-e2e-conformance-test-main

/test metal3-fullstack-build

/test metal3-node-image-building

/test metal3-ubuntu-e2e-basic-test-main

/test metal3-ubuntu-e2e-basic-test-release-1-10

/test metal3-ubuntu-e2e-basic-test-release-1-8

/test metal3-ubuntu-e2e-basic-test-release-1-9

/test metal3-ubuntu-e2e-capi-md-test-main

/test metal3-ubuntu-e2e-feature-test-main-features

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/test metal3-ubuntu-e2e-feature-test-main-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-10-features

/test metal3-ubuntu-e2e-feature-test-release-1-10-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-10-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-8-features

/test metal3-ubuntu-e2e-feature-test-release-1-8-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-8-remediation

/test metal3-ubuntu-e2e-feature-test-release-1-9-features

/test metal3-ubuntu-e2e-feature-test-release-1-9-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-9-remediation

/test metal3-ubuntu-e2e-integration-test-release-1-10

/test metal3-ubuntu-e2e-integration-test-release-1-8

/test metal3-ubuntu-e2e-integration-test-release-1-9

Use /test all to run the following jobs that were automatically triggered:

check-prow-config

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Sunnatillo
Copy link
Member Author

/test metal3-node-image-building

@tuminoid
Copy link
Member

tuminoid commented Aug 4, 2025

This seems fine, but has not been merged nor commented even. Is this still needed @Sunnatillo ?

smoshiur1237
smoshiur1237 reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sunnatillo do we still need this PR. If yes , I am approving. otherwise you can close it.
/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smoshiur1237
Once this PR has been reviewed and has the lgtm label, please assign tuminoid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smoshiur1237
Copy link
Member

/test metal3-ubuntu-e2e-integration-test-main

@Sunnatillo
Copy link
Member Author

@Sunnatillo do we still need this PR. If yes , I am approving. otherwise you can close it. /approve

Let's keep it for a while, I did not check it yet. I will address this as part of Predictable interface name improvement.

@Sunnatillo
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest Awaiting requested review from kashifest

1 more reviewer

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sunnatillo @metal3-io-bot @tuminoid @smoshiur1237