Skip to content

Conversation

nuhakala
Copy link
Member

@nuhakala nuhakala commented Aug 6, 2025

This PR adds the required elements and configuration to build openSUSE Leap 15.6 based elements for the CI.

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sunnatillo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2025
@nuhakala
Copy link
Member Author

nuhakala commented Aug 6, 2025

/hold
Lets put this on hold as well because of the dev env PR was also blocked until further discussion.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2025
Signed-off-by: Nuutti Hakala <nuutti.hakala@est.tech>
@nuhakala nuhakala force-pushed the nuhakala/ci-suse-images branch from 3f244d7 to e555196 Compare August 6, 2025 10:40
Comment on lines +33 to +39
# Patch DIB source to accept openSUSE Leap 15.6. This is merged into upstream
# but we have to wait for new release. Most likely will be in >3.39
python_version=$(python3 --version | awk '{print $2}')
python_version_minor=${python_version%.*}
sed -i "8i15.6) export OPENSUSE_REPO_DIR=openSUSE_Leap_\${DIB_RELEASE} ;;" \
"${REPO_ROOT}"venv/lib/python"${python_version_minor}"/site-packages/diskimage_builder/elements/opensuse/environment.d/10-opensuse-distro-name.bash

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the comment states, DIB does not allow any other versions than 15.5. A PR to accept also 15.6 is already merged, but it will take some time before it lands in a release. Hence I have this "quickfix" here for the moment being.

@metal3-io-bot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants