-
Notifications
You must be signed in to change notification settings - Fork 22
Automatically fetch latest pre-release k8s version #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically fetch latest pre-release k8s version #1074
Conversation
/test ? |
@erjavaskivuori: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test metal3-centos-e2e-integration-k8s-pre-release-test-main |
2e00d0f
to
dd46c1b
Compare
/test metal3-centos-e2e-integration-k8s-pre-release-test-main |
@erjavaskivuori: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dd46c1b
to
78be147
Compare
Fetch the latest pre-release k8s version for a spesified minor version. Signed-off-by: erjavaskivuori <erja.vaskivuori@est.tech>
78be147
to
e4cd939
Compare
Since the pipeline changes can't be tested by running the tests from here, I have these two runs where I tested the pipeline changes by replacing the pipeline with my changes:
Centos just failed in post steps because of nohup issue |
/cc @Sunnatillo |
Is this going to be a periodic or just a PR test? Otherwise nice work |
We discussed this elsewhere already, but as a summary; the periodic is already there but we can discuss again if that is needed. |
I agree with Adil here, we need this test only when new Kubernetes pre-releases are available. After GA release, we do not have to run. My suggestion to keep it in periodic table, and make it to run manually. Anyhow we need to set minor release version on new test, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sunnatillo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override metal3-ubuntu-e2e-integration-test-main |
@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
yes we can keep it in periodic and not run it, I am ok with that. |
Fetch the latest pre-release Kubernetes version for a specified minor version. This is to require less manual changes.