Disallow invalid states for ChatSessionItem
#263696
Open
+86
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This combines the state info into a single type so that you cannot create invalid states, such as `InProgress` with an endTime In the future this can also be used to more neatly add other metadata, such as a failure reason string for failed sessions
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
mjbvz
commented
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the state info into a single type so that you cannot create invalid states, such as
InProgresswith an endTimeIn the future this can also be used to more neatly add other metadata, such as a failure reason string for failed sessions