Skip to content

Code style change #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
May 23, 2023
Merged

Code style change #126

merged 24 commits into from
May 23, 2023

Conversation

Tristan22400
Copy link
Contributor

fix: #125

@Tristan22400 Tristan22400 self-assigned this Apr 28, 2023
@Tristan22400 Tristan22400 marked this pull request as ready for review May 2, 2023 12:28
@MathisGD
Copy link
Collaborator

MathisGD commented May 3, 2023 •
edited
Loading

This PR needs a rebase on #123

@Tristan22400 Tristan22400 marked this pull request as draft May 3, 2023 13:42
@Tristan22400 Tristan22400 marked this pull request as ready for review May 3, 2023 15:08
@Tristan22400 Tristan22400 changed the base branch from change-formatter to main May 3, 2023 15:08
@Tristan22400 Tristan22400 changed the base branch from main to change-formatter May 3, 2023 15:12
pakim249CAL
pakim249CAL previously approved these changes May 3, 2023
View reviewed changes
MerlinEgalite
MerlinEgalite previously approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have done the changes on the test but LGTM

@Tristan22400 Tristan22400 requested review from QGarchery and MathisGD May 4, 2023 07:48
Base automatically changed from change-formatter to main May 4, 2023 09:14
@Tristan22400 Tristan22400 marked this pull request as draft May 4, 2023 09:40
@Tristan22400 Tristan22400 dismissed stale reviews from MerlinEgalite and pakim249CAL via ffad642 May 4, 2023 12:52
@Tristan22400 Tristan22400 marked this pull request as ready for review May 4, 2023 13:11
MerlinEgalite
MerlinEgalite previously approved these changes May 5, 2023
View reviewed changes
pakim249CAL
pakim249CAL previously approved these changes May 5, 2023
View reviewed changes
makcandrov
makcandrov previously approved these changes May 9, 2023
View reviewed changes
@makcandrov makcandrov mentioned this pull request May 9, 2023
Merged
mlgarchery
mlgarchery reviewed May 9, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite merged commit e3a727e into main May 23, 2023
@MerlinEgalite MerlinEgalite deleted the code-style-change branch May 23, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Awaiting requested review from Rubilmax

@QGarchery QGarchery Awaiting requested review from QGarchery

@MathisGD MathisGD Awaiting requested review from MathisGD

@makcandrov makcandrov Awaiting requested review from makcandrov

+2 more reviewers

@mlgarchery mlgarchery mlgarchery left review comments

@pakim249CAL pakim249CAL pakim249CAL approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Tristan22400 Tristan22400

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conform to Morpho's style
6 participants
@Tristan22400 @MathisGD @mlgarchery @MerlinEgalite @pakim249CAL @makcandrov