Skip to content

Conversation

yaoyao22fanfan
Copy link
Contributor

[Unreleased]

Changed

  • fix: When running a linter through WSL, the file where the error occu)rred cannot be correctly indicated #530

@mshr-h mshr-h requested review from mshr-h and Copilot July 30, 2025 05:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where running a linter through WSL (Windows Subsystem for Linux) fails to correctly identify the file where errors occurred. The fix involves converting WSL paths to Windows format and cleaning up NUL characters from the output.

Key changes:

  • Added path conversion from WSL format to Windows format for proper file identification
  • Added cleanup of superfluous NUL characters from linter output
  • Minor code formatting improvements

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/linter/VerilatorLinter.ts Implements WSL path conversion and NUL character cleanup to fix file path resolution
CHANGELOG.md Documents the bug fix in the changelog
Comments suppressed due to low confidence (1)

src/linter/VerilatorLinter.ts:68

  • [nitpick] The function name 'convertFromWslPath' is ambiguous about the direction of conversion. Consider renaming to 'convertWslPathToWindows' to clearly indicate it converts from WSL format to Windows format.
  private convertFromWslPath(inputPath: string): string {

@mshr-h
Copy link
Owner

mshr-h commented Aug 15, 2025

The changes make sense to me.

@mshr-h mshr-h merged commit 977699c into mshr-h:main Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants