Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Conversation

henrifrancois
Copy link
Contributor

Adds support for Zola

Adds support for Zola
@henrifrancois henrifrancois changed the title feat: add Zola feat: add Zola type:feature Jun 29, 2021
@henrifrancois henrifrancois changed the title feat: add Zola type:feature feat: add Zola Jun 29, 2021
@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jun 30, 2021
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrifrancois!

You should require the JSON file in:

require('./cecil.json'),

Also how can we differentiate Zola from Hugo? See:

"configFiles": ["config.toml", "config.yaml"]

- Removed `config.yaml` option for configuration in `zola.json`.
- Place `require('./zola.json')` in the appropriate section in `frameworks/main.js`
@henrifrancois
Copy link
Contributor Author

After reviewing it seems Zola only uses a config.toml for its configuration options. I am unsure if that's a sufficient distinction between them both, however.

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking @henrifrancois.

I think this means that sometimes we'll detect both hugo and zola until we find a better way to do it (I believe we'll need to add support for pattern matching inside configuration files).

@@ -44,7 +44,7 @@
"react-dom": "^17.0.1",
"test-each": "^2.0.0",
"tmp-promise": "^3.0.2",
"webpack": "^5.41.0",
"webpack": "^5.10.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we undo this? Seems unrelated to the PR

@erezrokah erezrokah merged commit 2f571d9 into netlify:main Jul 5, 2021
@erezrokah
Copy link
Contributor

Thanks @henrifrancois, I opened #329 as a follow up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants