Skip to content

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Mar 17, 2025

Closes #5659

Added plotsr

@GallVp
Copy link
Member Author

GallVp commented Apr 2, 2025

Depends on #7829

Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by the usage of --genomes

Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for answering the different comments !
Could you just update the nf-test snapshot with the two following comments ?

Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the notifications.
I couldn't directly push to your branch.

@GallVp GallVp added this pull request to the merge queue Jul 13, 2025
@GallVp
Copy link
Member Author

GallVp commented Jul 13, 2025

Thank you very much @LouisLeNezet

Merged via the queue into nf-core:master with commit de48150 Jul 13, 2025
26 checks passed
@GallVp GallVp deleted the add/plotsr branch July 13, 2025 21:37
vmelichar pushed a commit to vmelichar/modules that referenced this pull request Jul 16, 2025
* Added plotsr

* Updated and moved params to test file

* Fixed test syntax

* Added meta map

* Responded to comments

* Update modules/nf-core/plotsr/tests/main.nf.test

* Update modules/nf-core/plotsr/tests/main.nf.test

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

---------

Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
vvvirgy pushed a commit to vvvirgy/modules that referenced this pull request Jul 29, 2025
* Added plotsr

* Updated and moved params to test file

* Fixed test syntax

* Added meta map

* Responded to comments

* Update modules/nf-core/plotsr/tests/main.nf.test

* Update modules/nf-core/plotsr/tests/main.nf.test

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

* Update modules/nf-core/plotsr/tests/main.nf.test.snap

---------

Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: PLOTSR
2 participants