#01 - The Medium Clap #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohansemmanuel
commented
Dec 30, 2019
| // 👉 prop from HOC | ||
| animationTimeline.replay() | ||
|
|
||
| setClapState({ |
There was a problem hiding this comment.
🔥 IMPROVEMENT:
Relying on the previous state when invoking the updater function returned from useState? It's better to pass a function to the updater e.g.
setClapState(prevState => ({
count: Math.min(prevState.count + 1, MAXIMUM_USER_CLAP),
countTotal: prevState.count < MAXIMUM_USER_CLAP ? prevState.countTotal + 1 : prevState.countTotal,
isClicked: true
}))
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about? 🤔
The initial implementation of the Medium clap via a class component
Changes 🎁
withClapAnimationmo.jsfor animationsBefore/After 📸
https://advanced-react-patterns-ultrasimplified.netlify.com/the-medium-clap
Other Comments 💬
Next PR: Refactor to Hooks