-
Notifications
You must be signed in to change notification settings - Fork 813
feat: gator test --deny-only flag #3809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gator test --deny-only flag #3809
Conversation
8448062
to
7dfd213
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3809 +/- ##
==========================================
- Coverage 54.49% 47.89% -6.61%
==========================================
Files 134 234 +100
Lines 12329 19881 +7552
==========================================
+ Hits 6719 9522 +2803
- Misses 5116 9470 +4354
- Partials 494 889 +395
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7dfd213
to
3304001
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, Thanks for the pr!
Signed-off-by: Steeve Chailloux <me@steeve.io>
3304001
to
84bb086
Compare
Thanks @JaydipGabani, |
@@ -86,6 +86,8 @@ cat my-manifest.yaml | gator test --image=localhost:5000/gator/template-library: | |||
--image=localhost:5000/gator/constraints:v1 | |||
``` | |||
|
|||
The `--deny-only` will only output violations about denied constraints, not the ones using `warn` enforcement action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @WnP ! can you pls add a note that this is only available after the v3.19 release. thanks!
@@ -86,6 +86,8 @@ cat my-manifest.yaml | gator test --image=localhost:5000/gator/template-library: | |||
--image=localhost:5000/gator/constraints:v1 | |||
``` | |||
|
|||
The `--deny-only` will only output violations about denied constraints, not the ones using `warn` enforcement action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `--deny-only` will only output violations about denied constraints, not the ones using `warn` enforcement action. | |
The `--deny-only` flag will only output violations about denied constraints, not the ones using `warn` enforcement action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
one nit
@WnP PTAL^^ |
Hi @JaydipGabani @ritazh, |
What this PR does / why we need it:
Add
--deny-only
flag togator test
command.Which issue(s) this PR fixes:
Fixes #3808