fix: add RBAC for finalizers when running with OwnerReferencesPermissionEnforcement admission plugin #3961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt admission plugin Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3961 +/- ##
===========================================
- Coverage 54.49% 38.97% -15.53%
===========================================
Files 134 236 +102
Lines 12329 20133 +7804
===========================================
+ Hits 6719 7847 +1128
- Misses 5116 11710 +6594
- Partials 494 576 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ritazh
reviewed
May 15, 2025
| @@ -247,6 +247,8 @@ type ReconcileConstraintTemplate struct { | |||
| // +kubebuilder:rbac:groups=templates.gatekeeper.sh,resources=constrainttemplates,verbs=get;list;watch;create;update;patch;delete | |||
| // +kubebuilder:rbac:groups=templates.gatekeeper.sh,resources=constrainttemplates/status,verbs=get;update;patch | |||
| // +kubebuilder:rbac:groups=externaldata.gatekeeper.sh,resources=providers,verbs=get;list;watch;create;update;patch;delete | |||
| // finalizers is needed for OwnerReferencesPermissionEnforcement admission plugin. | |||
| // +kubebuilder:rbac:groups=templates.gatekeeper.sh,resources=constrainttemplates/finalizers,verbs=get;update;patch;delete | |||
There was a problem hiding this comment.
Can you please add a link to where this is documented and verify if we need all these verbs or just the update one.
There was a problem hiding this comment.
update verb is enough, updated the rbac and added a link to documentation as well.
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
|
Can you also update the e2e (enable the OwnerReferencesPermissionEnforcement admission plugin) to test this? should fail without this clusterrole and succeed with it deployed). If we had the test, it would have caught the issue. |
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
|
@ritazh addded tests to create sample CT when admission plugin is enabled. |
sozercan
reviewed
Jun 11, 2025
ritazh
changed the title
ritazh
changed the title
grelland
pushed a commit
to grelland/gatekeeper
that referenced
this pull request
Jun 12, 2025
…ionEnforcement admission plugin (open-policy-agent#3961) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
dhaiducek
pushed a commit
to dhaiducek/gatekeeper
that referenced
this pull request
Jun 12, 2025
…ionEnforcement admission plugin (open-policy-agent#3961) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
openshift-merge-bot bot
pushed a commit
to stolostron/gatekeeper
that referenced
this pull request
Jun 13, 2025
…ionEnforcement admission plugin (open-policy-agent#3961) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
sozercan
pushed a commit
to sozercan/gatekeeper
that referenced
this pull request
Jun 18, 2025
…ionEnforcement admission plugin (open-policy-agent#3961) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
dhaiducek
pushed a commit
to dhaiducek/gatekeeper
that referenced
this pull request
Jul 29, 2025
…ionEnforcement admission plugin (open-policy-agent#3961) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3960
Special notes for your reviewer: