-
Notifications
You must be signed in to change notification settings - Fork 54
Do not push to quay the chatbot releases #3149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not push to quay the chatbot releases #3149
Conversation
WalkthroughThe push-to-master GitHub Actions workflow now excludes tags matching v*-chatbot from triggering. The on.push.tags list adds a negated filter '!v*-chatbot', maintaining existing triggers for v* and exclusions for cim and virt. No other files or logic were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/push-to-master.yaml (1)
39-43
: Defense-in-depth: also guard the job against chatbot tags.Optional, future-proofing in case new triggers are added (e.g., workflow_dispatch). Skip the publish job when the ref is a chatbot tag.
- publish-assisted-ui: + publish-assisted-ui: needs: preflight-check - if: needs.preflight-check.outputs.skip == 'false' + if: needs.preflight-check.outputs.skip == 'false' && !(github.ref_type == 'tag' && endsWith(github.ref_name, '-chatbot'))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/push-to-master.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: lint
- GitHub Check: circular-deps
- GitHub Check: tests
- GitHub Check: unit-tests
- GitHub Check: translation-files
- GitHub Check: format
🔇 Additional comments (1)
.github/workflows/push-to-master.yaml (1)
11-11
: Excluding v-chatbot tags from triggers aligns with the PR goal.*This prevents the workflow from running on chatbot release tags. Confirm whether chatbot tags can have extra suffixes (e.g., v1.2.3-chatbot.1). If yes, prefer a broader negate pattern.
- - '!v*-chatbot' + - '!v*-chatbot*'
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celdrake, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
861466b
into
openshift-assisted:master
/cherry-pick releases/v0.1-chatbot |
@celdrake: new pull request created: #3158 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary by CodeRabbit