Skip to content

Conversation

rawagner
Copy link
Member

@rawagner rawagner commented Aug 28, 2025

Summary by CodeRabbit

  • Chores
    • Updated release workflow triggers to exclude tags matching v*-chatbot from running the “push to master or release tag” pipeline, reducing unnecessary CI runs while preserving existing release and exclusion patterns.
    • No changes to application behavior or public interfaces.
    • No user-facing impact.

@openshift-ci openshift-ci bot requested review from ammont82 and ElayAharoni August 28, 2025 12:59
Copy link

coderabbitai bot commented Aug 28, 2025

Walkthrough

The push-to-master GitHub Actions workflow now excludes tags matching v*-chatbot from triggering. The on.push.tags list adds a negated filter '!v*-chatbot', maintaining existing triggers for v* and exclusions for cim and virt. No other files or logic were changed.

Changes

Cohort / File(s) Summary
Workflow trigger filter update
.github/workflows/push-to-master.yaml
Added negated tag filter !v*-chatbot under on.push.tags to prevent v*-chatbot tags from triggering the workflow; retained existing v* trigger and exclusions for cim and virt.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

lgtm, approved, size/XS

Suggested reviewers

  • ElayAharoni
  • jgyselov
  • ammont82

Poem

A tag hops by—v-something, not bot—
I twitch my ears: “Exclude that spot!”
Filters nibble, workflows stay neat,
Master sleeps sound, triggers discreet.
Thump-thump done; less noise, more plot. 🐇✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/push-to-master.yaml (1)

39-43: Defense-in-depth: also guard the job against chatbot tags.

Optional, future-proofing in case new triggers are added (e.g., workflow_dispatch). Skip the publish job when the ref is a chatbot tag.

-  publish-assisted-ui:
+  publish-assisted-ui:
     needs: preflight-check
-    if: needs.preflight-check.outputs.skip == 'false'
+    if: needs.preflight-check.outputs.skip == 'false' && !(github.ref_type == 'tag' && endsWith(github.ref_name, '-chatbot'))
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7a0b7a3 and ae6ba1b.

📒 Files selected for processing (1)
  • .github/workflows/push-to-master.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: lint
  • GitHub Check: circular-deps
  • GitHub Check: tests
  • GitHub Check: unit-tests
  • GitHub Check: translation-files
  • GitHub Check: format
🔇 Additional comments (1)
.github/workflows/push-to-master.yaml (1)

11-11: Excluding v-chatbot tags from triggers aligns with the PR goal.*

This prevents the workflow from running on chatbot release tags. Confirm whether chatbot tags can have extra suffixes (e.g., v1.2.3-chatbot.1). If yes, prefer a broader negate pattern.

-      - '!v*-chatbot'
+      - '!v*-chatbot*'

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
Copy link

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celdrake, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 861466b into openshift-assisted:master Sep 3, 2025
11 checks passed
@celdrake
Copy link
Contributor

celdrake commented Sep 4, 2025

/cherry-pick releases/v0.1-chatbot

@openshift-cherrypick-robot

@celdrake: new pull request created: #3158

In response to this:

/cherry-pick releases/v0.1-chatbot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants