NO-ISSUE: retry image pull in all cases #733
Conversation
another registry that doesn't have this specific image manifest and we will get manifest-unknown error and will not retry to pull it, removing this pretty small optimisation will allow us to retry in this case and make our code more error resilient
|
@tsorya: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Why would retrying suddenly fix this? - Is the registry redirect temporary? |
|
/lgtm |
|
/retest |
|
@tsorya: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
NO-ISSUE: in some registries (brew for example) we can get a redirect to another registry that doesn't have this specific image manifest and we will get manifest-unknown error and will not retry to pull it, removing this pretty small optimisation will allow us to retry in this case and make our code more error resilient
Background / Context
Issue / Requirement / Reason for change
Solution / Feature Overview
Implementation Details
Other Information