Skip to content

Conversation

leo8a
Copy link
Contributor

@leo8a leo8a commented Jul 16, 2025

Summary

Add missing kustomization.yaml file for the logging optional component in telco-hub pattern configuration. Fixes CNF-18820.

Changes

  • Add telco-hub/configuration/reference-crs/optional/logging/kustomization.yaml
  • Include references to all logging component resources:
    • clusterLogNS.yaml
    • clusterLogOperGroup.yaml
    • clusterLogSubscription.yaml

Context

As part of the validated pattern integration effort (CNF-13631), all optional components need proper kustomization support to enable flexible deployment configurations. This adds the missing kustomization file for the logging component following the same structure and conventions as other optional components.

Testing

  • Validated kustomization syntax is correct
  • All referenced resources exist in the logging directory
  • File follows established pattern conventions

Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com

@openshift-ci-robot
Copy link
Collaborator

@leo8a: This pull request references CNF-18820 which is a valid jira issue.

In response to this:

Summary

Add missing kustomization.yaml file for the logging optional component in telco-hub pattern configuration. Fixes CNF-18820.

Changes

  • Add telco-hub/configuration/reference-crs/optional/logging/kustomization.yaml
  • Include references to all logging component resources:
  • clusterLogNS.yaml
  • clusterLogOperGroup.yaml
  • clusterLogSubscription.yaml

Context

As part of the validated pattern integration effort (CNF-13631), all optional components need proper kustomization support to enable flexible deployment configurations. This adds the missing kustomization file for the logging component following the same structure and conventions as other optional components.

Testing

  • Validated kustomization syntax is correct
  • All referenced resources exist in the logging directory
  • File follows established pattern conventions

Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ffromani and MarSik July 16, 2025 21:16
Copy link

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leo8a
Once this PR has been reviewed and has the lgtm label, please assign irinamihai for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leo8a
Copy link
Contributor Author

leo8a commented Jul 16, 2025

/cc @imiller0

@openshift-ci openshift-ci bot requested a review from imiller0 July 16, 2025 21:16
Add kustomization.yaml for the cert-manager optional component in
telco-hub pattern configuration with proper resource references
for all cert-manager manifests including namespace, operator group,
subscription, cluster issuer, and certificate resources.

Relates-to: CNF-13631

Signed-off-by: Leonardo Ochoa-Aday <lochoa@redhat.com>
@leo8a leo8a force-pushed the fix-cert-manager branch from 05bae3e to 01f68c4 Compare July 16, 2025 21:50
@leo8a
Copy link
Contributor Author

leo8a commented Jul 17, 2025

/hold

doing some more testing for this one

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2025
@leo8a
Copy link
Contributor Author

leo8a commented Jul 23, 2025

/unhold

This optional component is not currently part of the telco-hub reference specification (see official docs).

Not sure if we should remove these resources till ready to be merged again or just wait. In either case, the associated kustomization.yaml file appears to be missing.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants