Skip to content

Conversation

leo8a
Copy link
Contributor

@leo8a leo8a commented Aug 21, 2025

When doing cluster-compare directly against the kustomize-patched CRs, the following drift can be seen:

Cluster CR: policy.open-cluster-management.io/v1_Policy_hub-policies_obs-thanos-secret
Reference File: required/acm/thanosSecretPolicy.yaml
Description:
  https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/scalability_and_performance/telco-hub-ref-design-specs#telco-hub-red-hat-advanced-cluster-management-rhacm_telco-hub
Diff Output: diff -u -N /tmp/MERGED-2209731535/policy-open-cluster-management-io-v1_policy_hub-policies_obs-thanos-secret /tmp/LIVE-2073721428/policy-open-cluster-management-io-v1_policy_hub-policies_obs-thanos-secret
--- /tmp/MERGED-2209731535/policy-open-cluster-management-io-v1_policy_hub-policies_obs-thanos-secret   2025-08-21 10:24:49.813111730 +0200
+++ /tmp/LIVE-2073721428/policy-open-cluster-management-io-v1_policy_hub-policies_obs-thanos-secret     2025-08-21 10:24:49.813111730 +0200
@@ -3,7 +3,7 @@
 metadata:
   annotations:
     argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
-    argocd.argoproj.io/sync-wave: "9"
+    argocd.argoproj.io/sync-wave: "-10"
     policy.open-cluster-management.io/categories: CM Configuration Management
     policy.open-cluster-management.io/controls: CM-2 Baseline Configuration
     policy.open-cluster-management.io/description: ""

**********************************

Even though in the reference-crs that Policy has assigned a sync-wave of -10. This wasn't caught up by the ci-validate target due to this file is included in the list of compare_ignore.

Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com

@openshift-ci openshift-ci bot requested review from ffromani and SchSeba August 21, 2025 08:29
Copy link

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leo8a
Once this PR has been reviewed and has the lgtm label, please assign irinamihai for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com
@leo8a
Copy link
Contributor Author

leo8a commented Aug 21, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant