MGMT-20830: Support for serving an OVE image (ISO) with an embedded custom ignition #449
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@omer-vishlitzky: This pull request references MGMT-20830 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omer-vishlitzky The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
omer-vishlitzky
force-pushed
the
omer-vishlitzky/main
branch
from
749597d to
919efe8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
+ Coverage 59.32% 59.40% +0.07%
==========================================
Files 27 27
Lines 1571 1579 +8
==========================================
+ Hits 932 938 +6
- Misses 478 479 +1
- Partials 161 162 +1
🚀 New features to boost your workflow:
|
internal/handlers/short.go
Outdated
| @@ -51,6 +51,8 @@ func parseShortURL(r *http.Request) (*imageDownloadParams, int, error) { | |||
| params.imageType = "minimal-iso" | |||
| case "full.iso": | |||
| params.imageType = "full-iso" | |||
| case "disconnected-interactive.iso": | |||
| params.imageType = "disconnected-interactive-iso" | |||
There was a problem hiding this comment.
This is the best name we have for this? It's fine if there are no other options, but it feels a bit unwieldy to me.
There was a problem hiding this comment.
Yeah, naming is hard:) Maybe simply 'disconnected.iso'? @andfasano wdyt?
There was a problem hiding this comment.
In this case I feel that the interactive part plays quite a relevant role, since it's a special ISO meant not only to support the disconnected installation (ie like the regular ABI ISO), but also to spin up a local agent TUI and moreover a complete assisted UI to support the interactive installation process by the user. Anyhow I don't want to block on this, if no other better ideas will come up I'm fine with disconnected.iso
There was a problem hiding this comment.
I see we're using OVE everywhere, is that not a good name for this? I guess it can be used for more than just installing virt and that's why we're avoiding it here?
There was a problem hiding this comment.
Exactly, OVE (virt) is just the current use-case. But a similar ISO could be used also for other scenarios which require different operators (ACM/etc). I.e. OVE is a specific flow which requires virt operators, but the ISO would support (later on) selecting other operators depending on the use-case.
There was a problem hiding this comment.
That's right, OVE is only the current scope, so it will be better to avoid using it in the naming for a more generic product
There was a problem hiding this comment.
In the context of assisted-service (where users will encounter this), all installs are interactive
disconnected-isoself-contained-isojumbo-iso
not gonna use the 'a' word 🙊
There was a problem hiding this comment.
I like just removing interactive.
+1 for disconnected-iso/disconnected.iso from me
|
/cc @andfasano |
omer-vishlitzky
force-pushed
the
omer-vishlitzky/main
branch
from
919efe8 to
65069e2
Compare
|
@omer-vishlitzky: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/MGMT-20830