MGMT-21395: Add monitoring label and Prometheus RBAC for supported OLM operators

[linoyaslan]

To provide a consistent, out-of-the-box monitoring experience, the Assisted Installer automatically enables cluster monitoring for all operators that support this feature (i.e., those with the "Enable Operator-recommended cluster monitoring..." option in OperatorHub). This choice is enabled by default and cannot be changed by the user during the assisted installation process. To enforce this, the Assisted Installer's code must perform two key actions for each monitoring-aware operator:

1. apply the openshift.io/cluster-monitoring=true label to the operator's pre-created namespace
2. if an operator does not provide its own RBAC, the installer code is responsible for creating the standard Prometheus Role and RoleBinding in the operator's namespace.

Note: When a developer adds a new operator to Assisted, they are responsible for the following:

1. Check the operator's CSV for the openshift.io/cluster-monitoring=true annotation. If the annotation is present, add the openshift.io/cluster-monitoring=true namespace label.
2. Check if the operator already includes its own Prometheus Role and RoleBinding. If not, add the logic to the installer to create them.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@linoyaslan: This pull request references MGMT-21395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

For operators with “Enable Operator-recommended cluster monitoring on this namespace” option in OperatorHub, Assisted treats it as always on (users can’t toggle it). Since we pre-create the operator namespaces, we must set openshift.io/cluster-monitoring=true by default for those operators.

Note: When new operators are added to Assisted, developers should verify whether their namespace requires this cluster-monitoring label and add it accordingly.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linoyaslan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [linoyaslan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@linoyaslan: This pull request references MGMT-21395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

For operators with “Enable Operator-recommended cluster monitoring on this namespace” option in OperatorHub, Assisted treats it as always on (users can’t toggle it). Since we pre-create the operator namespaces, we must set openshift.io/cluster-monitoring=true by default for those operators.

Note: When new operators are added to Assisted, developers should verify whether their namespace requires this cluster-monitoring label and add it accordingly.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[linoyaslan]

/cc @tiraboschi @danmanor

[openshift-ci-robot]

@linoyaslan: This pull request references MGMT-21395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

For operators with “Enable Operator-recommended cluster monitoring on this namespace” option in OperatorHub, Assisted treats it as always on (users can’t toggle it). Since we pre-create the operator namespaces, we must set openshift.io/cluster-monitoring=true by default for those operators.

Note: When new operators are added to Assisted, developers should verify whether their namespace requires this cluster-monitoring label and add it accordingly.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@linoyaslan: This pull request references MGMT-21395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

To provide a consistent, out-of-the-box monitoring experience, the Assisted Installer automatically enables cluster monitoring for all operators that support this feature (i.e., those with the "Enable Operator-recommended cluster monitoring..." option in OperatorHub). This choice is enabled by default and cannot be changed by the user during the assisted installation process. To enforce this, the Assisted Installer's code must perform two key actions for each monitoring-aware operator:

1. apply the openshift.io/cluster-monitoring=true label to the operator's pre-created namespace
2. if an operator does not provide its own RBAC, the installer code is responsible for creating the standard Prometheus Role and RoleBinding in the operator's namespace.

Note: When a developer adds a new operator to Assisted, they are responsible for the following:

1. Check the operator's CSV for the operatorframework.io/cluster-monitoring=true annotation. If the annotation is present, ensure the installer's code is updated to apply the monitoring label to that operator's namespace.
2. check if the operator already includes its own Prometheus Role and RoleBinding. If not, add the logic to the installer to create them.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@linoyaslan: This pull request references MGMT-21395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

To provide a consistent, out-of-the-box monitoring experience, the Assisted Installer automatically enables cluster monitoring for all operators that support this feature (i.e., those with the "Enable Operator-recommended cluster monitoring..." option in OperatorHub). This choice is enabled by default and cannot be changed by the user during the assisted installation process. To enforce this, the Assisted Installer's code must perform two key actions for each monitoring-aware operator:

1. apply the openshift.io/cluster-monitoring=true label to the operator's pre-created namespace
2. if an operator does not provide its own RBAC, the installer code is responsible for creating the standard Prometheus Role and RoleBinding in the operator's namespace.

Note: When a developer adds a new operator to Assisted, they are responsible for the following:

1. Check the operator's CSV for the operatorframework.io/cluster-monitoring=true annotation. If the annotation is present, ensure the installer's code is updated to apply the monitoring label to that operator's namespace.
2. Check if the operator already includes its own Prometheus Role and RoleBinding. If not, add the logic to the installer to create them.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@linoyaslan: This pull request references MGMT-21395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

To provide a consistent, out-of-the-box monitoring experience, the Assisted Installer automatically enables cluster monitoring for all operators that support this feature (i.e., those with the "Enable Operator-recommended cluster monitoring..." option in OperatorHub). This choice is enabled by default and cannot be changed by the user during the assisted installation process. To enforce this, the Assisted Installer's code must perform two key actions for each monitoring-aware operator:

1. apply the openshift.io/cluster-monitoring=true label to the operator's pre-created namespace
2. if an operator does not provide its own RBAC, the installer code is responsible for creating the standard Prometheus Role and RoleBinding in the operator's namespace.

Note: When a developer adds a new operator to Assisted, they are responsible for the following:

1. Check the operator's CSV for the openshift.io/cluster-monitoring=true annotation. If the annotation is present, ensure the installer's code is updated to apply the monitoring label to that operator's namespace.
2. Check if the operator already includes its own Prometheus Role and RoleBinding. If not, add the logic to the installer to create them.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@linoyaslan: This pull request references MGMT-21395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

To provide a consistent, out-of-the-box monitoring experience, the Assisted Installer automatically enables cluster monitoring for all operators that support this feature (i.e., those with the "Enable Operator-recommended cluster monitoring..." option in OperatorHub). This choice is enabled by default and cannot be changed by the user during the assisted installation process. To enforce this, the Assisted Installer's code must perform two key actions for each monitoring-aware operator:

1. apply the openshift.io/cluster-monitoring=true label to the operator's pre-created namespace
2. if an operator does not provide its own RBAC, the installer code is responsible for creating the standard Prometheus Role and RoleBinding in the operator's namespace.

Note: When a developer adds a new operator to Assisted, they are responsible for the following:

1. Check the operator's CSV for the openshift.io/cluster-monitoring=true annotation. If the annotation is present, add the openshift.io/cluster-monitoring=true namespace label.
2. Check if the operator already includes its own Prometheus Role and RoleBinding. If not, add the logic to the installer to create them.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[linoyaslan]

/cc @tiraboschi @danmanor I'd appreciate your review, thanks!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.68%. Comparing base (b9c6e63) to head (fc18ffc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7949   +/-   ##
=======================================
  Coverage   73.67%   73.68%           
=======================================
  Files         400      400           
  Lines       68565    68567    +2     
=======================================
+ Hits        50516    50522    +6     
+ Misses      15338    15336    -2     
+ Partials     2711     2709    -2     

Files with missing lines	Coverage Δ
internal/operators/lso/manifest.go	81.81% <100.00%> (+1.17%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[linoyaslan]

/retest

[pastequo]

/lgtm

[linoyaslan]

/retest

[pastequo]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b9c6e63 and 2 for PR HEAD fc18ffc in total

[openshift-ci]

@linoyaslan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.