CONSOLE-4675: Enable strictNullChecks: true for olm and olm-v1

frontend/packages/console-app/src/components/user-preferences/UserPreferenceForm.tsx

@@ -8,7 +8,7 @@ import './UserPreferenceForm.scss';
 type UserPreferenceFormProps = { items: ResolvedUserPreferenceItem[] };
 
 const UserPreferenceForm: React.FC<UserPreferenceFormProps> = ({ items }) =>
-  items?.length > 0 ? (
+  items && items.length > 0 ? (
     <Form onSubmit={(event) => event.preventDefault()} className="co-user-preference__form">
       {items.map((item) => (
         <UserPreferenceField key={item.id} item={item} />

frontend/packages/console-app/src/components/user-preferences/UserPreferencePage.tsx

@@ -1,4 +1,5 @@
 import * as React from 'react';
+import { useState } from 'react';
 import {
   Tabs,
   Tab,
@@ -57,8 +58,9 @@ const UserPreferencePage: React.FC = () => {
   const { group: groupIdFromUrl } = useParams();
   const initialTabId =
     sortedUserPreferenceGroups.find((extension) => extension.id === groupIdFromUrl)?.id ||
-    sortedUserPreferenceGroups[0]?.id;
-  const [activeTabId, setActiveTabId] = React.useState<string>(initialTabId);
+    sortedUserPreferenceGroups[0]?.id ||
+    'general';
+  const [activeTabId, setActiveTabId] = useState<string>(initialTabId);
 
   const [userPreferenceTabs, userPreferenceTabContents] = React.useMemo<
     [React.ReactElement<TabProps>[], React.ReactElement<TabContentProps>[]]

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot-content-details.tsx

@@ -28,7 +28,8 @@ const { editYaml, events } = navFactory;
 
 const Details: React.FC<DetailsProps> = ({ obj }) => {
   const { t } = useTranslation();
-  const { deletionPolicy, driver } = obj?.spec;
+  const deletionPolicy = obj?.spec?.deletionPolicy || '';
+  const driver = obj?.spec?.driver || '';
   const { volumeHandle, snapshotHandle } = obj?.spec?.source || {};
   const { name: snapshotName, namespace: snapshotNamespace } = obj?.spec?.volumeSnapshotRef || {};
   const size = obj.status?.restoreSize;

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot-content.tsx

@@ -43,8 +43,10 @@ export const tableColumnInfo = [
 ];
 
 const Row: React.FC<RowProps<VolumeSnapshotContentKind>> = ({ obj }) => {
-  const { name, creationTimestamp } = obj?.metadata || {};
-  const { name: snapshotName, namespace: snapshotNamespace } = obj?.spec?.volumeSnapshotRef || {};
+  const name = obj?.metadata?.name || '';
+  const creationTimestamp = obj?.metadata?.creationTimestamp || '';
+  const snapshotName = obj?.spec?.volumeSnapshotRef?.name || '';
+  const snapshotNamespace = obj?.spec?.volumeSnapshotRef?.namespace || '';
   const size = obj.status?.restoreSize;
   const sizeMetrics = size ? humanizeBinaryBytes(size).string : '-';
 

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot-details.tsx

@@ -40,7 +40,7 @@ const { editYaml, events } = navFactory;
 
 const Details: React.FC<DetailsProps> = ({ obj }) => {
   const { t } = useTranslation();
-  const { namespace } = obj.metadata || {};
+  const namespace = obj?.metadata?.namespace || '';
   const sourceModel = obj?.spec?.source?.persistentVolumeClaimName
     ? PersistentVolumeClaimModel
     : VolumeSnapshotContentModel;

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot.tsx

@@ -129,7 +129,9 @@ const Row: React.FC<RowProps<VolumeSnapshotKind, VolumeSnapshotRowProsCustomData
   obj,
   rowData: { customData },
 }) => {
-  const { name, namespace, creationTimestamp } = obj?.metadata || {};
+  const name = obj?.metadata?.name || '';
+  const namespace = obj?.metadata?.namespace || '';
+  const creationTimestamp = obj?.metadata?.creationTimestamp || '';
   const size = obj?.status?.restoreSize;
   const sizeBase = convertToBaseValue(size);
   const sizeMetrics = size ? humanizeBinaryBytes(sizeBase).string : '-';

frontend/packages/operator-lifecycle-manager-v1/src/contexts/types.ts

@@ -1,4 +1,5 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 export type ExtensionCatalogDatabaseContextValues = {
   done: boolean;
-  error: Error;
+  error: Error | null;
 };

frontend/packages/operator-lifecycle-manager-v1/src/contexts/useExtensionCatalogDatabaseContextValues.ts

@@ -1,4 +1,5 @@
-import { useState, useRef, useEffect } from 'react';
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
+import { useEffect, useRef, useState } from 'react';
 import * as _ from 'lodash';
 import { K8sResourceCommon } from '@console/dynamic-plugin-sdk/src';
 import { useK8sWatchResource } from '@console/dynamic-plugin-sdk/src/api/core-api';
@@ -13,7 +14,7 @@ export const useExtensionCatalogDatabaseContextValues: UseExtensionCatalogDataba
     isList: true,
   });
   const [done, setDone] = useState(false);
-  const [error, setError] = useState<Error>();
+  const [error, setError] = useState<Error | null>(null);
   const refresh = useRef(
     _.debounce((newCatalogs: K8sResourceCommon[]) => {
       setDone(false);

frontend/packages/operator-lifecycle-manager-v1/src/database/injest.ts

@@ -1,3 +1,4 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 /* eslint-disable no-console */
 import { K8sResourceCommon } from '@console/dynamic-plugin-sdk/src/lib-core';
 import { bundleHasProperty } from '../fbc/bundles';
@@ -22,7 +23,7 @@ const streamFBCObjectsToIndexedDB = (
 ): Promise<number> =>
   reader.read().then(async ({ done, value }) => {
     if (done) {
-      return count;
+      return count ?? 0;
     }
     if (
       isFileBasedCatalogBundle(value) &&
@@ -43,13 +44,13 @@ const injestClusterCatalog = async (
   db: IDBDatabase,
   catalog: K8sResourceCommon,
 ): Promise<number> => {
-  const catalogName = catalog.metadata.name;
+  const catalogName = catalog.metadata?.name;
   console.log('[Extension Catalog Database] Injesting FBC from ClusterCatalog', catalogName);
   return fetchAndProcessJSONLines<FileBasedCatalogObject>(
     `/api/catalogd/catalogs/${catalogName}/api/v1/all`,
     { 'Content-Type': 'application/jsonl' },
   )
-    .then((reader) => streamFBCObjectsToIndexedDB(db, catalogName, reader))
+    .then((reader) => streamFBCObjectsToIndexedDB(db, catalogName || '', reader))
     .then((count) => {
       console.log(
         '[Extension Catalog Database] Successfully injested',

frontend/packages/operator-lifecycle-manager-v1/src/database/jsonl.ts

@@ -31,6 +31,7 @@ export const parseJSONLines = <ObjectType>() =>
     },
   });
 
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 // ObjectType is the expected shape of each JSON object (defaults to any).
 // HandlerResult is the expected value the handler will resolve when called with ObjectType as an argument
 export const fetchAndProcessJSONLines = <ObjectType = any>(
@@ -41,6 +42,9 @@ export const fetchAndProcessJSONLines = <ObjectType = any>(
     if (!response.ok) {
       throw new Error(`Failed to fetch ${url}: ${response.statusText}`);
     }
+    if (!response.body) {
+      throw new Error(`Response body is null for ${url}`);
+    }
     return response.body
       .pipeThrough(new TextDecoderStream())
       .pipeThrough<ObjectType>(parseJSONLines<ObjectType>())

frontend/packages/operator-lifecycle-manager-v1/src/database/types.ts

@@ -1,3 +1,4 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 import { InfrastructureFeature } from '@console/operator-lifecycle-manager/src/components/operator-hub';
 
 export enum FileBasedCatalogSchema {

frontend/packages/operator-lifecycle-manager-v1/src/fbc/bundles.ts

@@ -1,3 +1,4 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 import * as SemVer from 'semver';
 import { getIndexedItems } from '../database/indexeddb';
 import { getBundleMetadata } from './metadata';
@@ -15,7 +16,7 @@ const getBundleVersion = (bundle: FileBasedCatalogBundle): SemVer.SemVer => {
   const versionString =
     getBundleProperty<PackagePropertyValue>(bundle, FileBasedCatalogPropertyType.Package)
       ?.version || '';
-  return SemVer.parse(versionString);
+  return SemVer.parse(versionString) ?? new SemVer.SemVer('0.0.0');
 };
 
 export const compareBundleVersions = (

frontend/packages/operator-lifecycle-manager-v1/src/fbc/catalog-item.tsx

@@ -1,3 +1,4 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 import { CatalogItem } from '@console/dynamic-plugin-sdk/src';
 import { SyncMarkdownView } from '@console/internal/components/markdown-view';
 import { CapabilityLevel } from '@console/operator-lifecycle-manager/src/components/operator-hub/operator-hub-item-details';
@@ -29,7 +30,7 @@ export const normalizeExtensionCatalogItem: NormalizeExtensionCatalogItem = (pkg
     createdAt,
   } = pkg;
   const [validSubscriptions, validSubscriptionFilters] = validSubscriptionReducer(
-    validSubscription,
+    validSubscription ?? [],
   );
   return {
     attributes: {
@@ -50,7 +51,7 @@ export const normalizeExtensionCatalogItem: NormalizeExtensionCatalogItem = (pkg
       properties: [
         {
           label: 'Capability level',
-          value: <CapabilityLevel capability={capabilities} />,
+          value: <CapabilityLevel capability={capabilities ?? ''} />,
         },
         { label: 'Source', value: source || '-' },
         { label: 'Provider', value: provider || '-' },
@@ -77,7 +78,7 @@ export const normalizeExtensionCatalogItem: NormalizeExtensionCatalogItem = (pkg
       descriptions: [{ value: <SyncMarkdownView content={longDescription} /> }],
     },
     displayName,
-    icon: icon ? { url: `data:${icon.mediatype};base64,${icon.base64data}` } : null,
+    icon: icon ? { url: `data:${icon.mediatype};base64,${icon.base64data}` } : undefined,
     name: displayName || name,
     supportUrl: support,
     provider,

frontend/packages/operator-lifecycle-manager-v1/src/fbc/metadata.ts

@@ -1,3 +1,4 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 /* eslint-disable no-console */
 import * as _ from 'lodash';
 import {
@@ -139,7 +140,7 @@ const aggregateMetadata = (
   csvMetadata: CSVMetadata,
   packageMetadata?: PackageMetadata,
 ): PackageMetadata => {
-  if (!csvMetadata) return packageMetadata;
+  if (!csvMetadata) return packageMetadata ?? {};
   return Object.keys(csvMetadata)
     .sort() // ensure annotations are handled first
     .reduce((acc, key) => {

frontend/packages/operator-lifecycle-manager-v1/src/fbc/packages.ts

@@ -1,3 +1,4 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 /* eslint-disable no-console */
 import { defaultClusterCatalogSourceMap } from '@console/operator-lifecycle-manager/src/components/operator-hub/operator-hub-utils';
 import { PackageSource } from '@console/operator-lifecycle-manager/src/const';
@@ -40,7 +41,7 @@ export const addPackagesToExtensionCatalog = (
           pkg.name,
           e.toString(),
         );
-        return null;
+        throw e;
       }),
     ),
   );

frontend/packages/operator-lifecycle-manager-v1/src/fbc/types.ts

@@ -1,3 +1,4 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 import {
   InfrastructureFeature,
   OLMAnnotation,

frontend/packages/operator-lifecycle-manager-v1/src/hooks/useExtensionCatalogCategories.ts

@@ -1,12 +1,22 @@
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
 import * as React from 'react';
 import { CatalogCategory } from '@console/dynamic-plugin-sdk/src';
 import { usePoll } from '@console/internal/components/utils';
 import { ExtensionCatalogDatabaseContext } from '../contexts/ExtensionCatalogDatabaseContext';
 import { getUniqueIndexKeys, openDatabase } from '../database/indexeddb';
 
-export const useExtensionCatalogCategories = (): CatalogCategory[] => {
+export const useExtensionCatalogCategories = (): [CatalogCategory[], boolean, string] => {
   const { done: initDone, error: initError } = React.useContext(ExtensionCatalogDatabaseContext);
-  const [categories, setCategories] = React.useState([]);
+  const [categories, setCategories] = React.useState<IDBValidKey[]>([]);
+  const [loading, setLoading] = React.useState(!initDone);
+  const [error, setError] = React.useState(initError.toString() || '');
+
+  React.useEffect(() => {
+    if (!initDone || initError) {
+      setLoading(!initDone);
+      setError(initError.toString() || '');
+    }
+  }, [initDone, initError]);
 
   const tick = React.useCallback(() => {
     if (initDone && !initError) {
@@ -24,10 +34,10 @@ export const useExtensionCatalogCategories = (): CatalogCategory[] => {
   // Poll IndexedDB (IDB) every 10 seconds
   usePoll(tick, 10000);
   const catalogCategories = React.useMemo<CatalogCategory[]>(
-    () => categories.map((c) => ({ id: c, label: c, tags: [c] })),
+    () => categories.map((c) => ({ id: c as string, label: c as string, tags: [c as string] })),
     [categories],
   );
-  return catalogCategories;
+  return [catalogCategories, loading, error];
 };
 
 export default useExtensionCatalogCategories;

frontend/packages/operator-lifecycle-manager-v1/src/hooks/useExtensionCatalogItems.ts

@@ -1,26 +1,27 @@
-import { useContext, useState, useEffect, useCallback, useMemo } from 'react';
+// This file will be removed as part of https://issues.redhat.com//browse/CONSOLE-4668
+import * as React from 'react';
 import { CatalogItem } from '@console/dynamic-plugin-sdk/src';
 import { usePoll } from '@console/internal/components/utils';
 import { ExtensionCatalogDatabaseContext } from '../contexts/ExtensionCatalogDatabaseContext';
 import { getItems, openDatabase } from '../database/indexeddb';
 import { normalizeExtensionCatalogItem } from '../fbc/catalog-item';
 import { ExtensionCatalogItem } from '../fbc/types';
 
-type UseExtensionCatalogItems = () => [CatalogItem[], boolean, Error];
+type UseExtensionCatalogItems = () => [CatalogItem[], boolean, Error | null];
 export const useExtensionCatalogItems: UseExtensionCatalogItems = () => {
-  const { done: initDone, error: initError } = useContext(ExtensionCatalogDatabaseContext);
-  const [items, setItems] = useState<ExtensionCatalogItem[]>([]);
-  const [loading, setLoading] = useState(true);
-  const [error, setError] = useState<Error>();
+  const { done: initDone, error: initError } = React.useContext(ExtensionCatalogDatabaseContext);
+  const [items, setItems] = React.useState<ExtensionCatalogItem[]>([]);
+  const [loading, setLoading] = React.useState(true);
+  const [error, setError] = React.useState<Error | null>(null);
 
-  useEffect(() => {
+  React.useEffect(() => {
     if (!initDone || initError) {
       setLoading(!initDone);
       setError(initError);
     }
   }, [initDone, initError]);
 
-  const tick = useCallback(() => {
+  const tick = React.useCallback(() => {
     if (initDone && !initError) {
       openDatabase('olm')
         .then((database) => getItems<ExtensionCatalogItem>(database, 'extension-catalog'))
@@ -40,9 +41,10 @@ export const useExtensionCatalogItems: UseExtensionCatalogItems = () => {
   // Poll IndexedDB (IDB) every 10 seconds
   usePoll(tick, 10000);
 
-  const normalizedItems = useMemo<CatalogItem[]>(() => items.map(normalizeExtensionCatalogItem), [
-    items,
-  ]);
+  const normalizedItems = React.useMemo<CatalogItem[]>(
+    () => items.map(normalizeExtensionCatalogItem),
+    [items],
+  );
 
   return [normalizedItems, loading, error];
 };