Skip to content

CONSOLE-4606: [METAL3] Drop createModalLauncher and use useOverlay hook instead. #15394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CONSOLE-4606: [METAL3] Drop createModalLauncher and use useOverlay hook instead. #15394

wants to merge 1 commit into from

Conversation

krishagarwal278
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2025 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4606 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2025
@openshift-ci openshift-ci bot requested review from jhadvig and rawagner August 12, 2025 18:42
@openshift-ci openshift-ci bot added the component/metal3 Related to metal3-plugin label Aug 12, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krishagarwal278
Once this PR has been reviewed and has the lgtm label, please assign rawagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krishagarwal278 krishagarwal278 changed the title [WIP]CONSOLE-4606: [METAL3] Drop createModalLauncher and use useOverlay hook instead. CONSOLE-4606: [METAL3] Drop createModalLauncher and use useOverlay hook instead. Aug 13, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2025
@krishagarwal278
Copy link
Member Author

/retest

1 similar comment
@krishagarwal278
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

@krishagarwal278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend babadbd link true /test frontend
ci/prow/okd-scos-e2e-aws-ovn babadbd link false /test okd-scos-e2e-aws-ovn
ci/prow/analyze babadbd link true /test analyze
ci/prow/okd-scos-images babadbd link true /test okd-scos-images
ci/prow/images babadbd link true /test images
ci/prow/e2e-gcp-console babadbd link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Mylanos
Mylanos reviewed Aug 14, 2025
View reviewed changes
frontend/packages/metal3-plugin/src/components/baremetal-hosts/host-menu-actions.tsx
});
});
};

export const useMenuActionsCreator = (
Copy link
Contributor

@Mylanos Mylanos Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You introduced this hook, but haven't actually replaced themenuActionsCreator, that we are targeting to replace and also remove the menuActions. We should remove menuActionsCreator and menuActions.

Mylanos
Mylanos reviewed Aug 14, 2025
View reviewed changes
frontend/packages/metal3-plugin/src/components/modals/PowerOffHostModal.tsx
submitDisabled={!canPowerOffSafely && !forceOff}
submitText={t('metal3-plugin~Power Off')}
return (
<Modal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring the existing modals was out of scope of this story, but kudos for going for it anyway. Be sure to test it out if there are not some visual discrepancies, its hard for me to test this out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your suggestion on launching a bare metal cluster. Should be able to test out my changes soon.

Mylanos
Mylanos reviewed Aug 14, 2025
View reviewed changes
frontend/packages/metal3-plugin/src/plugin.tsx
@@ -22,7 +22,8 @@ import {
import { HOST_POWER_STATUS_POWERING_OFF, HOST_POWER_STATUS_POWERING_ON } from './constants';
import {
detectBaremetalPlatform,
BAREMETAL_FLAG,
// BAREMETAL_FLAG,
BMO_ENABLED_FLAG,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for testing/development purposes?

Mylanos
Mylanos reviewed Aug 14, 2025
View reviewed changes
frontend/packages/metal3-plugin/src/components/baremetal-hosts/BareMetalHostDetailsPage.tsx
bmoEnabled,
t,
}}
customActionMenu={customActionMenu}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robb figured out that we can also do:

Suggested change
customActionMenu={customActionMenu}
customActionMenu={(kindObj: K8sModel, obj: K8sResourceKind) => (
<LazyActionMenu context={{ [referenceForModel(BareMetalHostModel)]: obj }} variant={ActionMenuVariant.DROPDOWN} />
)}

and remove the customActionMenu above.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@rawagner rawagner Awaiting requested review from rawagner

1 more reviewer

@Mylanos Mylanos Mylanos left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
component/metal3 Related to metal3-plugin jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krishagarwal278 @openshift-ci-robot @openshift-merge-robot @Mylanos