Skip to content

CONSOLE-4683: Refactor group action factory #15404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

CONSOLE-4683: Refactor group action factory #15404

merged 1 commit into from
Sep 3, 2025

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Aug 14, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 14, 2025 •
edited by openshift-ci bot
Loading

@jhadvig: This pull request references CONSOLE-4683 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and Mylanos August 14, 2025 13:26
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2025
@jhadvig
Copy link
Member Author

jhadvig commented Aug 14, 2025

/retest

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 14, 2025
@jhadvig jhadvig force-pushed the CONSOLE-4683 branch 2 times, most recently from 09cc65e to fc868d3 Compare August 18, 2025 12:02
@jhadvig jhadvig changed the title [WIP] CONSOLE-4683: Refactor group action factory CONSOLE-4683: Refactor group action factory Aug 18, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
Mylanos
Mylanos reviewed Aug 18, 2025
View reviewed changes
frontend/public/components/group.tsx Outdated

return (
<DetailsPage
{...props}
kind={referenceForModel(GroupModel)}
menuActions={[getImpersonateAction(startImpersonate, navigate), ...menuActions]}
customActionMenu={customActionMenu}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly fine, but we have just started applying different pattern here:

Suggested change
customActionMenu={customActionMenu}
customActionMenu={(obj: K8sResourceKind) => (
<LazyActionMenu context={{ [referenceForModel(GroupModel)]: obj }} />
)}

@Mylanos
Copy link
Contributor

Mylanos commented Aug 18, 2025

you gotta update i18n @jhadvig

Mylanos
Mylanos reviewed Aug 18, 2025
View reviewed changes
frontend/public/components/group.tsx Outdated
};

const menuActions = [addUsers, ...Kebab.factory.common];
// i18next removed; using useTranslation()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of undeleted comments?

@jhadvig jhadvig force-pushed the CONSOLE-4683 branch 2 times, most recently from cbfdac2 to 0dab15e Compare August 18, 2025 14:18
Mylanos
Mylanos reviewed Aug 18, 2025
View reviewed changes
Mylanos
Mylanos reviewed Aug 18, 2025
View reviewed changes
Mylanos
Mylanos reviewed Aug 18, 2025
View reviewed changes
Mylanos
Mylanos reviewed Aug 18, 2025
View reviewed changes
Mylanos
Mylanos reviewed Aug 18, 2025
View reviewed changes
frontend/public/components/group.tsx Outdated
onConfirm: () => {
const value = (group.users || []).filter((u: string) => u !== user);
return k8sPatchResource({
model: (GroupModel as unknown) as any,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
model: (GroupModel as unknown) as any,
model: GroupModel,

Mylanos
Mylanos reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@Mylanos Mylanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just couple of minor nits, otherwise this is in a good shape.

logonoff
logonoff reviewed Aug 18, 2025
View reviewed changes
frontend/packages/console-app/src/actions/hooks/useGroupActions.ts Outdated
Comment on lines 22 to 27
const startImpersonate = React.useCallback(
(kind: string, name: string) => dispatch(UIActions.startImpersonate(kind, name)),
[dispatch],
);

const factory = React.useMemo(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should move away from react namespace imports in new code per https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#removing-unused-react-imports

Suggested change
const startImpersonate = React.useCallback(
(kind: string, name: string) => dispatch(UIActions.startImpersonate(kind, name)),
[dispatch],
);
const factory = React.useMemo(
const startImpersonate = useCallback(
(kind: string, name: string) => dispatch(UIActions.startImpersonate(kind, name)),
[dispatch],
);
const factory = useMemo(

logonoff
logonoff reviewed Aug 18, 2025
View reviewed changes
frontend/packages/console-app/src/components/modals/add-group-users-modal.tsx Outdated
const [inProgress, setInProgress] = React.useState<boolean>(false);
const [errorMessage, setErrorMessage] = React.useState<string>('');

const onSubmit: React.MouseEventHandler<HTMLButtonElement> = async (e) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const onSubmit: React.MouseEventHandler<HTMLButtonElement> = async (e) => {
const onSubmit: MouseEventHandler<HTMLButtonElement> = async (e) => {

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 11adfac and 2 for PR HEAD 7218076 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 56f4245 and 2 for PR HEAD 7218076 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 11df15c and 1 for PR HEAD 7218076 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1efe5db and 2 for PR HEAD 7218076 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f161d7d and 2 for PR HEAD 7218076 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7e36f21 and 1 for PR HEAD 7218076 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 35d5c3b and 2 for PR HEAD 7218076 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2025
@Mylanos
Copy link
Contributor

Mylanos commented Sep 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Mylanos
Copy link
Contributor

Mylanos commented Sep 1, 2025

/label acknowledge-critical-fixes-only

Tech debt

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 1, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9f35a5e and 2 for PR HEAD 31d3935 in total

@Mylanos
Copy link
Contributor

Mylanos commented Sep 2, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhadvig jhadvig added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Sep 2, 2025
@jhadvig
Copy link
Member Author

jhadvig commented Sep 3, 2025

/verified

@openshift-ci-robot
Copy link
Contributor

@jhadvig: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member Author

jhadvig commented Sep 3, 2025

/verified later

@openshift-ci-robot
Copy link
Contributor

@jhadvig: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

In response to this:

/verified later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member Author

jhadvig commented Sep 3, 2025

/verified later @yapei

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 3, 2025
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This PR has been marked to be verified later by @yapei.

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 44a3816 into openshift:main Sep 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cajieh cajieh Awaiting requested review from cajieh

2 more reviewers

@logonoff logonoff logonoff left review comments

@Mylanos Mylanos Mylanos left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Mylanos Mylanos

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria verified-later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jhadvig @openshift-ci-robot @Mylanos @yanpzhan @logonoff @openshift-merge-robot