Skip to content

Conversation

adamviktora
Copy link

@adamviktora adamviktora commented Aug 14, 2025

When kubevirt-plugin is installed, this will be added:

  • a "Set as default for VirtualMachines" option in StorageClass actions dropdown. It sets storageclass.kubevirt.io/is-default-virt-class annotation to true
  • "Default for VirtualMachines" indicator to a StorageClass in a list

After:

Screen.Recording.2025-08-15.at.10.15.31.mov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 14, 2025

@adamviktora: This pull request references CNV-64586 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

In StorageClass actions -> "Set as default" option sets storageclass.kubevirt.io/is-default-virt-class annotation to true when kubevirt-plugin is installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Mylanos and spadgett August 14, 2025 15:35
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Aug 14, 2025
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adamviktora
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 14, 2025

@adamviktora: This pull request references CNV-64586 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

In StorageClass actions -> "Set as default" option sets storageclass.kubevirt.io/is-default-virt-class annotation to true when kubevirt-plugin is installed

After:

Screen.Recording.2025-08-14.at.17.25.40.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adamviktora adamviktora force-pushed the storageclass-default-virt-class branch from 7074fbf to 0ecbed4 Compare August 15, 2025 08:53
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 15, 2025
@adamviktora adamviktora changed the title CNV-64586: "Set as default" option should set is-default-virt-class CNV-64586: add ability to set default storageclass for VMs Aug 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2025

@adamviktora: This pull request references CNV-64586 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

When kubevirt-plugin is installed, this will be added:

  • a "Set as default for VirtualMachines" option in StorageClass actions dropdown. It sets storageclass.kubevirt.io/is-default-virt-class annotation to true
  • "Default for VirtualMachines" indicator to a StorageClass in a list

After:

Screen.Recording.2025-08-15.at.10.15.31.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2025
@adamviktora adamviktora force-pushed the storageclass-default-virt-class branch from 0ecbed4 to 0e1ee8c Compare August 21, 2025 06:46
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2025
@adamviktora
Copy link
Author

/retest

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@adamviktora: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 0e1ee8c link true /test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants