CONSOLE-4695: Fixed SNC errors in /components/ lightspeed | modals | nav | file-upload #15413

krishagarwal278 · 2025-08-18T20:34:31Z

Fixed SNC related errors in
/console-app/src/components/{packages/console-ap/src/components/ lightspeed | modals | nav | file-upload}

krishagarwal278 · 2025-08-18T20:34:51Z

/label px-approved
/label docs-approved

openshift-ci · 2025-08-18T20:34:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krishagarwal278
Once this PR has been reviewed and has the lgtm label, please assign mylanos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-08-18T20:35:11Z

@krishagarwal278: This pull request references CONSOLE-4695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Fixed SNC related errors in
/console-app/src/components/{packages/console-ap/src/components/ lightspeed | modals | nav | file-upload}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

krishagarwal278 · 2025-08-18T20:35:15Z

/jira refresh

openshift-ci-robot · 2025-08-18T20:35:19Z

@krishagarwal278: This pull request references CONSOLE-4695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

krishagarwal278 · 2025-08-19T14:21:44Z

/retest

logonoff · 2025-08-20T20:04:28Z

/cc

logonoff · 2025-08-20T20:05:25Z

frontend/packages/console-app/src/components/file-upload/file-upload-context.ts

@@ -13,8 +13,8 @@ export type FileUploadContextType = {
  setFileUpload: (file: File) => void;
 };

-export const FileUploadContext = createContext<FileUploadContextType>({
-  fileUpload: undefined,
+export const FileUploadContext = React.createContext<FileUploadContextType>({


the namespace import returned as a result of merge conflict resolution

Suggested change

export const FileUploadContext = React.createContext<FileUploadContextType>({

export const FileUploadContext = createContext<FileUploadContextType>({

Yes, will remove namespace imports throughout this and other PRs

logonoff · 2025-08-20T20:05:58Z

frontend/packages/console-app/src/components/file-upload/file-upload-context.ts

-export const FileUploadContext = createContext<FileUploadContextType>({
-  fileUpload: undefined,
+export const FileUploadContext = React.createContext<FileUploadContextType>({
+  fileUpload: undefined as any,


can we update FileUploadContextType to be File | undefined instead?

logonoff · 2025-08-20T20:07:46Z

frontend/packages/console-app/src/components/file-upload/file-upload-context.ts

@@ -26,8 +26,8 @@ export const useValuesFileUploadContext = (): FileUploadContextType => {
  const [fileUploadExtensions, resolved] = useResolvedExtensions<FileUpload>(isFileUpload);
  const toastContext = useToast();
  const [namespace] = useActiveNamespace();
-  const [file, setFile] = useState<File>(undefined);
-  const fileExtensions = useMemo(
+  const [file, setFile] = React.useState<File>(undefined as any);


i believe asserting types as any is an antipattern (as it inhibits type checking) and should be avoided in new/future code

Suggested change

const [file, setFile] = React.useState<File>(undefined as any);

const [file, setFile] = useState<File | undefined>(undefined);

Agreed. It'll defeat the purpose of type checking. I'll revert instances of any wherever i notice it

logonoff · 2025-08-20T20:09:22Z

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx

-      close();
-      history.push(resourceObjPath(cloneResource, referenceFor(cloneResource)));
+      close?.();
+      history.push(resourceObjPath(cloneResource, referenceFor(cloneResource)) as any);


same comment about usage of as any

logonoff · 2025-08-20T20:09:32Z

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx

@@ -262,7 +264,7 @@ const ClonePVCModal = withHandlePromise((props: ClonePVCModalProps) => {
        submitDisabled={!validSize || !pvcSC}
        errorMessage={errorMessage}
        submitText={t('console-app~Clone')}
-        cancel={cancel}
+        cancel={cancel as any}


same comment about usage of as any

logonoff · 2025-08-20T20:09:58Z

frontend/packages/console-app/src/components/nav/NavHeader.tsx

+          appendTo: () =>
+            document.querySelector("[data-test-id='perspective-switcher-toggle']") as HTMLElement,


does this work?

Suggested change

appendTo: () =>

document.querySelector("[data-test-id='perspective-switcher-toggle']") as HTMLElement,

appendTo: () =>

document.querySelector<HTMLElement>("[data-test-id='perspective-switcher-toggle']"),

Yeah it removed the type error earlier. We can also use generic type instead

logonoff · 2025-08-20T20:10:20Z

frontend/packages/console-app/src/components/nav/PinnedResource.tsx

@@ -151,7 +152,7 @@ const PinnedResource: React.FC<PinnedResourceProps> = ({
        'oc-pinned-resource--dragging': draggable && isOver,
      })}
    >
-      {draggable ? <DraggableButton dragRef={drag} /> : null}
+      {draggable ? <DraggableButton dragRef={drag as any} /> : null}


insert as any comment here

logonoff · 2025-08-20T20:10:58Z

frontend/public/components/factory/modal.tsx

@@ -268,7 +268,7 @@ export type ModalSubmitFooterProps = {
  message?: string;
  errorMessage?: string;
  inProgress: boolean;
-  cancel: (e: React.SyntheticEvent<any, Event>) => void;
+  cancel?: (e: React.SyntheticEvent<any, Event>) => void;


given how we're trying to deprecate and rewrite these modals I don't think we should change the proptype if possible

yanpzhan · 2025-08-21T11:27:29Z

Local tsc check passed against the files in pr code and regression test passed on cluster launched against the pr.
/label qe-approved

openshift-ci-robot · 2025-08-21T11:27:35Z

@krishagarwal278: This pull request references CONSOLE-4695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Fixed SNC related errors in
/console-app/src/components/{packages/console-ap/src/components/ lightspeed | modals | nav | file-upload}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

krishagarwal278 · 2025-08-21T13:35:45Z

/retest

krishagarwal278 · 2025-08-21T19:48:16Z

/retest

logonoff · 2025-08-21T19:53:13Z

frontend/packages/console-app/src/components/nav/NavHeader.tsx

+          appendTo: () => {
+            const element = document.querySelector<HTMLElement>(
+              "[data-test-id='perspective-switcher-toggle']",
+            );
+            return element || document.body;
+          },


does e2e still work with this change?

Suggested change

appendTo: () => {

const element = document.querySelector<HTMLElement>(

"[data-test-id='perspective-switcher-toggle']",

);

return element || document.body;

},

appendTo: "inline"

krishagarwal278 · 2025-08-21T20:42:46Z

/label tide/merge-method-squash

…/src/components/ lightspeed | modals | nav | file-upload} modified: frontend/packages/console-app/src/components/file-upload/__tests__/file-upload-utils.spec.ts modified: frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx modified: frontend/packages/console-app/src/components/modals/resource-limits/ResourceLimitsModalLauncher.tsx modified: frontend/packages/console-app/src/components/modals/restore-pvc/restore-pvc-modal.tsx modified: frontend/packages/console-app/src/components/nav/NavHeader.tsx modified: frontend/packages/console-app/src/components/nav/PinnedResource.tsx modified: frontend/packages/console-app/src/components/nav/PluginNavItem.tsx modified: frontend/packages/console-app/src/components/nav/utils.ts modified: frontend/public/components/factory/modal.tsx

openshift-ci · 2025-08-27T22:43:35Z

@krishagarwal278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/frontend	`3040319`	link	true	`/test frontend`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from jhadvig and kyoto August 18, 2025 20:34

openshift-ci bot added the component/core Related to console core functionality label Aug 18, 2025

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Aug 18, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 18, 2025

openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 19, 2025

openshift-ci bot requested a review from logonoff August 20, 2025 20:04

logonoff reviewed Aug 20, 2025

View reviewed changes

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 21, 2025

krishagarwal278 requested a review from logonoff August 21, 2025 19:48

logonoff reviewed Aug 21, 2025

View reviewed changes

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 21, 2025

krishagarwal278 force-pushed the CONSOLE-4695 branch from 318c354 to bce3f4e Compare August 26, 2025 19:12

Fixed test failures

3040319

krishagarwal278 force-pushed the CONSOLE-4695 branch from bce3f4e to 3040319 Compare August 27, 2025 18:07

openshift-ci bot added the component/topology Related to topology label Aug 27, 2025

	export const FileUploadContext = React.createContext<FileUploadContextType>({
	export const FileUploadContext = createContext<FileUploadContextType>({

	const [file, setFile] = React.useState<File>(undefined as any);
	const [file, setFile] = useState<File \| undefined>(undefined);

		appendTo: () =>
		document.querySelector("[data-test-id='perspective-switcher-toggle']") as HTMLElement,

CONSOLE-4695: Fixed SNC errors in /components/ lightspeed | modals | nav | file-upload #15413

Are you sure you want to change the base?

CONSOLE-4695: Fixed SNC errors in /components/ lightspeed | modals | nav | file-upload #15413

Uh oh!

Conversation

krishagarwal278 commented Aug 18, 2025

Uh oh!

krishagarwal278 commented Aug 18, 2025

Uh oh!

openshift-ci bot commented Aug 18, 2025

Uh oh!

openshift-ci-robot commented Aug 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishagarwal278 commented Aug 18, 2025

Uh oh!

openshift-ci-robot commented Aug 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishagarwal278 commented Aug 19, 2025

Uh oh!

logonoff commented Aug 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yanpzhan commented Aug 21, 2025

Uh oh!

openshift-ci-robot commented Aug 21, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishagarwal278 commented Aug 21, 2025

Uh oh!

krishagarwal278 commented Aug 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krishagarwal278 commented Aug 21, 2025

Uh oh!

openshift-ci bot commented Aug 27, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 18, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 18, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 21, 2025 •

edited by openshift-ci bot

Loading