CONSOLE-4674: Enable SNC to true in frontend/dev-console #15435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/packages/dev-console/src/components/health-checks/__tests__/AddHealthChecksForm.spec.tsx frontend/packages/dev-console/src/components/import/advanced/__tests__/RouteSection.spec.tsx frontend/packages/dev-console/src/components/import/devfile/devfileHooks.ts First commit modified: frontend/packages/console-dynamic-plugin-sdk/src/api/common-types.ts modified: frontend/packages/dev-console/src/actions/__tests__/add-resources.spec.tsx modified: frontend/packages/dev-console/src/actions/context-menu.ts modified: frontend/packages/dev-console/src/actions/creators.ts modified: frontend/packages/dev-console/src/actions/providers.tsx modified: frontend/packages/dev-console/src/components/QueryFocusApplication.tsx modified: frontend/packages/dev-console/src/components/add/AddCard.tsx modified: frontend/packages/dev-console/src/components/add/AddCardItem.tsx modified: frontend/packages/dev-console/src/components/add/AddPage.tsx modified: frontend/packages/dev-console/src/components/add/AddPageConfiguration.tsx modified: frontend/packages/dev-console/src/components/add/__tests__/AddCardItem.spec.tsx modified: frontend/packages/dev-console/src/components/add/layout/Masonry.tsx modified: frontend/packages/dev-console/src/components/add/layout/MasonryLayout.tsx modified: frontend/packages/dev-console/src/components/buildconfig/BuildConfigForm.tsx modified: frontend/packages/dev-console/src/components/buildconfig/BuildConfigFormPage.tsx modified: frontend/packages/dev-console/src/components/buildconfig/form-utils/__tests__/convert-to-buildconfig.spec.ts modified: frontend/packages/dev-console/src/components/buildconfig/form-utils/__tests__/convert-to-form.spec.ts modified: frontend/packages/dev-console/src/components/buildconfig/form-utils/convert-to-buildconfig.ts modified: frontend/packages/dev-console/src/components/buildconfig/form-utils/convert-to-form.ts modified: frontend/packages/dev-console/src/components/buildconfig/form-utils/initial-data.ts modified: frontend/packages/dev-console/src/components/buildconfig/sections/SecretsSection.tsx modified: frontend/packages/dev-console/src/components/buildconfig/sections/TriggersSection.tsx modified: frontend/packages/dev-console/src/components/builds/BuildsTabListPage.tsx modified: frontend/packages/dev-console/src/components/catalog/CatalogPage.tsx modified: frontend/packages/dev-console/src/components/catalog/CatalogTypesConfiguration.tsx modified: frontend/packages/dev-console/src/components/catalog/PinnedResourcesConfiguration.tsx modified: frontend/packages/dev-console/src/components/catalog/providers/useBindableItemMetadataProvider.ts modified: frontend/packages/dev-console/src/components/catalog/providers/useBuilderImageSamples.ts modified: frontend/packages/dev-console/src/components/catalog/providers/useBuilderImages.tsx modified: frontend/packages/dev-console/src/components/catalog/providers/useConsoleSamples.tsx modified: frontend/packages/dev-console/src/components/catalog/providers/useDevfile.tsx modified: frontend/packages/dev-console/src/components/catalog/providers/useTemplates.tsx modified: frontend/packages/dev-console/src/components/deployments/DeploymentConfigPage.tsx modified: frontend/packages/dev-console/src/components/deployments/DeploymentForm.tsx modified: frontend/packages/dev-console/src/components/deployments/DeploymentPage.tsx modified: frontend/packages/dev-console/src/components/deployments/EditDeployment.tsx modified: frontend/packages/dev-console/src/components/deployments/utils/deployment-validation-utils.ts modified: frontend/packages/dev-console/src/components/edit-application/EditApplication.tsx modified: frontend/packages/dev-console/src/components/edit-application/EditApplicationForm.tsx modified: frontend/packages/dev-console/src/components/edit-application/EditApplicationPage.tsx modified: frontend/packages/dev-console/src/components/edit-application/__tests__/edit-application-data.ts modified: frontend/packages/dev-console/src/components/edit-application/edit-application-types.ts modified: frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts modified: frontend/packages/dev-console/src/components/health-checks/AddHealthChecks.tsx modified: frontend/packages/dev-console/src/components/health-checks/AddHealthChecksForm.tsx modified: frontend/packages/dev-console/src/components/health-checks/HealthCheckProbe.tsx modified: frontend/packages/dev-console/src/components/health-checks/HealthChecksPage.tsx modified: frontend/packages/dev-console/src/components/health-checks/ProbeForm.tsx modified: frontend/packages/dev-console/src/components/health-checks/RequestTypeForms.tsx modified: frontend/packages/dev-console/src/components/health-checks/__tests__/create-health-check-probe-utils.spec.ts modified: frontend/packages/dev-console/src/components/health-checks/__tests__/create-health-checks-probe-data.ts modified: frontend/packages/dev-console/src/components/health-checks/health-checks-probe-utils.ts modified: frontend/packages/dev-console/src/components/health-checks/health-checks-utils.ts modified: frontend/packages/dev-console/src/components/hpa/HpaOverview.tsx modified: frontend/packages/dev-console/src/components/hpa/__tests__/hpa-utils-data.ts modified: frontend/packages/dev-console/src/components/hpa/hpa-utils.ts modified: frontend/packages/dev-console/src/components/import/__mocks__/deployImage-validation-mock.ts modified: frontend/packages/dev-console/src/components/import/__mocks__/import-toast-mock.ts modified: frontend/packages/dev-console/src/components/import/__mocks__/import-validation-mock.ts modified: frontend/packages/dev-console/src/components/import/__mocks__/upload-jar-mock.ts modified: frontend/packages/dev-console/src/components/import/__tests__/deployImage-submit-utils-data.ts modified: frontend/packages/dev-console/src/components/import/__tests__/import-submit-utils-data.ts modified: frontend/packages/dev-console/src/components/import/advanced/AdvancedSection.tsx modified: frontend/packages/dev-console/src/components/import/advanced/RouteSection.tsx modified: frontend/packages/dev-console/src/components/import/advanced/__tests__/RouteSection.spec.tsx modified: frontend/packages/dev-console/src/components/import/builder/BuilderImageSelector.tsx modified: frontend/packages/dev-console/src/components/import/devfile/DevfileStrategySection.tsx modified: frontend/packages/dev-console/src/components/import/devfile/devfile-utils.ts modified: frontend/packages/dev-console/src/components/import/devfile/devfileHooks.ts modified: frontend/packages/dev-console/src/components/import/git/DockerSection.tsx modified: frontend/packages/dev-console/src/components/import/git/GitSection.tsx modified: frontend/packages/dev-console/src/components/import/icon/IconDropdown.tsx modified: frontend/packages/dev-console/src/components/import/image-search/ImageSearch.tsx
frontend/packages/dev-console/src/components/project-access/__tests__/ProjectAccess.spec.tsx frontend/packages/dev-console/src/components/topology/bindable-services/bindable-service-context.ts modified: frontend/packages/dev-console/src/components/catalog/providers/__tests__/useConsoleSamples.spec.ts modified: frontend/packages/dev-console/src/components/deployments/utils/deployment-utils.ts modified: frontend/packages/dev-console/src/components/edit-application/EditApplicationComponent.tsx modified: frontend/packages/dev-console/src/components/edit-application/__tests__/edit-application-utils.spec.ts modified: frontend/packages/dev-console/src/components/health-checks/create-health-checks-probe-utils.ts modified: frontend/packages/dev-console/src/components/hpa/HPAPage.tsx modified: frontend/packages/dev-console/src/components/hpa/HPAUtilizationField.tsx modified: frontend/packages/dev-console/src/components/import/__tests__/import-submit-utils.spec.ts modified: frontend/packages/dev-console/src/components/import/image-search/__tests__/ImageStream.spec.tsx modified: frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverview.tsx modified: frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverviewAlerts.tsx modified: frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverviewEvents.tsx modified: frontend/packages/dev-console/src/components/monitoring/overview/MonitoringTab.tsx modified: frontend/packages/dev-console/src/components/monitoring/overview/__tests__/MonitoringOverview.spec.tsx modified: frontend/packages/dev-console/src/components/monitoring/queries.ts modified: frontend/packages/dev-console/src/components/project-access/ProjectAccess.tsx modified: frontend/packages/dev-console/src/components/project-access/ProjectAccessForm.tsx modified: frontend/packages/dev-console/src/components/project-access/ProjectAccessPage.tsx modified: frontend/packages/dev-console/src/components/project-access/ProjectAccessRolesConfiguration.tsx modified: frontend/packages/dev-console/src/components/project-access/__tests__/hooks.spec.ts modified: frontend/packages/dev-console/src/components/project-access/__tests__/project-access-form-data.ts modified: frontend/packages/dev-console/src/components/project-access/project-access-form-submit-utils.ts modified: frontend/packages/dev-console/src/components/project-access/project-access-form-utils.ts modified: frontend/packages/dev-console/src/components/projects/CreateProjectListPage.tsx modified: frontend/packages/dev-console/src/components/resource-quota/ResourceQuotaAlert.tsx modified: frontend/packages/dev-console/src/components/topology/bindable-services/data-transformer.ts modified: frontend/packages/dev-console/src/components/topology/bindable-services/isBindable.ts modified: frontend/packages/dev-console/src/components/topology/components/devConsoleComponentFactory.ts modified: frontend/packages/dev-console/src/components/topology/observe-tab-section.tsx modified: frontend/packages/dev-console/src/components/user-preferences/SecureRouteFields.tsx modified: frontend/packages/dev-console/src/components/user-preferences/__tests__/SecureRouteFields.spec.tsx modified: frontend/packages/dev-console/src/utils/add-page-utils.ts modified: frontend/packages/dev-console/src/utils/imagestream-utils.ts modified: frontend/packages/dev-console/src/utils/resource-label-utils.ts modified: frontend/packages/dev-console/src/utils/safe-k8s-hook.tsx modified: frontend/packages/dev-console/src/utils/samples.ts modified: frontend/packages/dev-console/src/utils/serverless-functions.ts modified: frontend/packages/dev-console/src/utils/shared-submit-utils.ts
frontend/packages/dev-console/src/components/import/advanced/__tests__/RouteSection.spec.tsx modified: frontend/packages/dev-console/src/components/buildconfig/sections/__tests__/ImagesSection.spec.tsx modified: frontend/packages/dev-console/src/components/buildconfig/sections/__tests__/PolicySection.spec.tsx modified: frontend/packages/dev-console/src/components/buildconfig/sections/__tests__/SourceSection.spec.tsx modified: frontend/packages/dev-console/src/components/catalog/providers/useDevfileSamples.tsx modified: frontend/packages/dev-console/src/components/deployments/__tests__/DeploymentForm.spec.tsx modified: frontend/packages/dev-console/src/components/deployments/__tests__/EnvironmentVariablesSection.spec.tsx modified: frontend/packages/dev-console/src/components/deployments/__tests__/ImagesSection.spec.tsx modified: frontend/packages/dev-console/src/components/deployments/deployment-strategy/advanced-options/LifecycleHookField.tsx modified: frontend/packages/dev-console/src/components/deployments/deployment-strategy/utils/deployment-strategy-utils.ts modified: frontend/packages/dev-console/src/components/edit-application/EditApplicationComponent.tsx modified: frontend/packages/dev-console/src/components/edit-application/__tests__/EditApplicationForm.spec.tsx modified: frontend/packages/dev-console/src/components/health-checks/__tests__/AddHealthChecksForm.spec.tsx modified: frontend/packages/dev-console/src/components/health-checks/create-health-checks-probe-utils.ts modified: frontend/packages/dev-console/src/components/hpa/HPADetailsForm.tsx modified: frontend/packages/dev-console/src/components/hpa/HPAPage.tsx modified: frontend/packages/dev-console/src/components/hpa/HPAUtilizationField.tsx modified: frontend/packages/dev-console/src/components/hpa/__tests__/hpa-utils.spec.ts modified: frontend/packages/dev-console/src/components/import/CreateSecretModal.tsx modified: frontend/packages/dev-console/src/components/import/DeployImage.tsx modified: frontend/packages/dev-console/src/components/import/DeployImageForm.tsx modified: frontend/packages/dev-console/src/components/import/DeployImagePage.tsx modified: frontend/packages/dev-console/src/components/import/GitImportForm.tsx modified: frontend/packages/dev-console/src/components/import/ImportForm.tsx modified: frontend/packages/dev-console/src/components/import/ImportPage.tsx modified: frontend/packages/dev-console/src/components/import/ImportSamplePage.tsx modified: frontend/packages/dev-console/src/components/import/ImportStrategySection.tsx modified: frontend/packages/dev-console/src/components/import/SamplesCatalog.tsx modified: frontend/packages/dev-console/src/components/import/SourceToImageForm.tsx modified: frontend/packages/dev-console/src/components/import/__tests__/deployImage-submit-utils.spec.ts modified: frontend/packages/dev-console/src/components/import/__tests__/import-submit-utils.spec.ts modified: frontend/packages/dev-console/src/components/import/__tests__/serverless-common-tests.ts modified: frontend/packages/dev-console/src/components/import/deployImage-submit-utils.ts modified: frontend/packages/dev-console/src/components/import/form-initial-values.ts modified: frontend/packages/dev-console/src/components/import/image-search/ImageStream.tsx modified: frontend/packages/dev-console/src/components/import/image-search/ImageStreamDropdown.tsx modified: frontend/packages/dev-console/src/components/import/image-search/ImageStreamNsDropdown.tsx modified: frontend/packages/dev-console/src/components/import/image-search/ImageStreamTagDropdown.tsx modified: frontend/packages/dev-console/src/components/import/import-submit-utils.ts modified: frontend/packages/dev-console/src/components/import/import-types.ts modified: frontend/packages/dev-console/src/components/import/import-validation-utils.ts modified: frontend/packages/dev-console/src/components/import/jar/UploadJar.tsx modified: frontend/packages/dev-console/src/components/import/jar/UploadJarPage.tsx modified: frontend/packages/dev-console/src/components/import/jar/__tests__/UploadJar.spec.tsx modified: frontend/packages/dev-console/src/components/import/jar/section/JarSection.tsx modified: frontend/packages/dev-console/src/components/import/render-utils.tsx modified: frontend/packages/dev-console/src/components/import/route/SecureRoute.tsx modified: frontend/packages/dev-console/src/components/import/serverless/__tests__/ServerlessRouteSection.spec.tsx modified: frontend/packages/dev-console/src/components/import/serverless/__tests__/serverless-utils.spec.ts modified: frontend/packages/dev-console/src/components/import/serverless/useGetAutoscalerConfig.ts modified: frontend/packages/dev-console/src/components/import/upload-jar-submit-utils.ts modified: frontend/public/locales/en/public.json
openshift-ci-robot
added
the
jira/valid-reference
|
@krishagarwal278: This pull request references CONSOLE-4674 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: krishagarwal278 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
component/dev-console
|
/label tide/merge-method-squash |
openshift-ci
bot
added
the
tide/merge-method-squash
|
/label docs-approved |
openshift-ci
bot
added
docs-approved
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
@krishagarwal278: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.