NO-JIRA: Improve error message in vsphere-plugin

[celdrake]

Whenever the "cloud-provider-config" ConfigMap has different data that the UI expects, the edition of the vsphere connection details fails and there's no helpful information about why it failed.

Now, we clearly display what data that we cannot find in the initial ConfigMap is preventing us from making the changes the user requested.

[celdrake]

/retest

[logonoff]

/label NO-JIRA: Improve error message in vsphere-plugin

[logonoff]

/retitle NO-JIRA: Improve error message in vsphere-plugin

[openshift-ci-robot]

@celdrake: This pull request explicitly references no jira issue.

In response to this:

Whenever the "cloud-provider-config" ConfigMap has different data that the UI expects, the edition of the vsphere connection details fails and there's no helpful information about why it failed.

Now, we clearly display what data that we cannot find in the initial ConfigMap is preventing us from making the changes the user requested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

the extra space and punctuation in this string is causing duplicate strings to appear in the locales json file

Suggested change

	t('Failed to parse cloud provider config {{cm}}. ', {
	t('Failed to parse cloud provider config {{cm}}', {

[celdrake]

Absolutely right, thanks! I'm fixing it now.

[logonoff]

/approve

/label tide/merge-method-squash
/label px-approved
/label docs-approved

qe review:
/assign @yapei

code review:
/assign @rhamilto

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celdrake, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/vsphere-plugin/OWNERS [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@celdrake: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yapei]

@yanpzhan is working on PR verification

[yanpzhan]

@celdrake I'm trying to verify the pr. Could you point me which resource field you modified to trigger the error? Thanks in advance.

[celdrake]

@yanpzhan What I did is to create a cluster using ClusterBot with the instruction "launch 4.17 vsphere".
This created a configuration where the folder and the resourcepool-path mismatch between several CRDs.

Then any modification should trigger the issue. Try modifying the folder for example.

[yanpzhan]

@celdrake This is the warning info when I update 'Virtual Machine Folder * ' field with '/DEVQEdatacenter-2/vm/prtest', seems not the expected info.

[celdrake]

@yanpzhan In this case, it seems your vsphere settings are all correct. Therefore no error is displayed when you make any changes to the Vsphere connection details, and they can be successfully updated (which is the happy path).

My PR only adds extra information when the vsphere settings have mismatches between different CRDs. Is it possible for you to check with the clusterBot's cluster?

[yanpzhan]

Reproduced the issue on 4.17 cluster, bridge console with the pr code, now there is more detailed failure info.
before on 4.17:

after:

/label qe-approved