Skip to content

[WIP] UPSTREAM: <carry>: add http logging for kubelet metrics endpoint #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] UPSTREAM: <carry>: add http logging for kubelet metrics endpoint #2396

wants to merge 2 commits into from

Conversation

tkashem
Copy link

@tkashem tkashem commented Aug 4, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2025
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 4, 2025
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from rphillips and sjenning August 4, 2025 20:40
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@tkashem tkashem force-pushed the kubelet-metrics-logger branch from 257247a to eefd04f Compare August 5, 2025 21:33
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem tkashem force-pushed the kubelet-metrics-logger branch from eefd04f to 8e01753 Compare August 6, 2025 15:09
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem tkashem force-pushed the kubelet-metrics-logger branch from 8e01753 to 9b516d9 Compare August 6, 2025 16:26
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem
Copy link
Author

tkashem commented Aug 6, 2025

/test e2e-gcp

1 similar comment
@tkashem
Copy link
Author

tkashem commented Aug 7, 2025

/test e2e-gcp

@tkashem tkashem force-pushed the kubelet-metrics-logger branch from 9b516d9 to 750fa27 Compare August 7, 2025 15:27
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem
Copy link
Author

tkashem commented Aug 7, 2025

/test e2e-gcp

1 similar comment
@tkashem
Copy link
Author

tkashem commented Aug 7, 2025

/test e2e-gcp

@tkashem tkashem force-pushed the kubelet-metrics-logger branch from 750fa27 to 6127a7c Compare August 8, 2025 14:44
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem tkashem force-pushed the kubelet-metrics-logger branch from 53cefc6 to ce4c3a3 Compare August 11, 2025 20:05
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem tkashem force-pushed the kubelet-metrics-logger branch from ce4c3a3 to 3bb2b61 Compare August 11, 2025 20:17
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem tkashem force-pushed the kubelet-metrics-logger branch from 3bb2b61 to 487cf51 Compare August 12, 2025 14:22
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 12, 2025

@tkashem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 257247a link false /test e2e-azure
ci/prow/e2e-aws-disruptive 257247a link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack 257247a link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws 257247a link false /test e2e-aws
ci/prow/e2e-openstack-csi-cinder 257247a link false /test e2e-openstack-csi-cinder
ci/prow/e2e-aws-single-node 257247a link false /test e2e-aws-single-node
ci/prow/e2e-openstack-csi-manila 257247a link false /test e2e-openstack-csi-manila
ci/prow/e2e-metal-ipi-ovn-ipv6 6127a7c link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-cgroupsv2 487cf51 link true /test e2e-aws-ovn-cgroupsv2
ci/prow/k8s-e2e-conformance-aws 487cf51 link true /test k8s-e2e-conformance-aws
ci/prow/e2e-aws-ovn-hypershift 487cf51 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-techpreview-serial 487cf51 link false /test e2e-aws-ovn-techpreview-serial
ci/prow/e2e-aws-ovn-techpreview 487cf51 link false /test e2e-aws-ovn-techpreview
ci/prow/k8s-e2e-aws-ovn-serial 487cf51 link false /test k8s-e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-runc 487cf51 link true /test e2e-aws-ovn-runc
ci/prow/e2e-aws-crun-wasm 487cf51 link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-fips 487cf51 link true /test e2e-aws-ovn-fips
ci/prow/okd-scos-e2e-aws-ovn 487cf51 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial 487cf51 link true /test e2e-aws-ovn-serial
ci/prow/e2e-agnostic-ovn-cmd 487cf51 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-csi 487cf51 link false /test e2e-aws-csi
ci/prow/e2e-aws-ovn-crun 487cf51 link true /test e2e-aws-ovn-crun
ci/prow/images 487cf51 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rphillips
rphillips reviewed Aug 12, 2025
View reviewed changes
pkg/kubelet/asyncinvoker/invoker.go
}

func (i *asyncInvoker[T]) Run(stopCtx context.Context) context.Context {
done, cancel := context.WithCancel(context.Background())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of context.Background(), perhaps pass in the stopCtx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@rphillips rphillips rphillips left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkashem @openshift-ci-robot @rphillips