Skip to content

Conversation

bitoku
Copy link

@bitoku bitoku commented Aug 21, 2025

What type of PR is this?

/kind flake

What this PR does / why we need it:

context: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1755784753878089?thread_ts=1755692105.699389&cid=C01CQA76KMX

We're pretty sure that the flakiness is caused by CPU pressure on the cluster, but it'll take some time to decide what to do (e.g. increase node sizes, increases the number of nodes, or reducing the parallelism).

This is a temporary measure to deflake the tests and once we fix the CPU pressure on the cluster, we can drop this change.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


…U pressure

Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@openshift-ci-robot
Copy link

@bitoku: No Jira issue with key OCPNODE-59735 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind flake

What this PR does / why we need it:

context: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1755784753878089?thread_ts=1755692105.699389&cid=C01CQA76KMX

We're pretty sure that the flakiness is caused by CPU pressure on the cluster, but it'll take some time to decide what to do (e.g. increase node sizes, increases the number of nodes, or reducing the parallelism).

This is a temporary measure to deflake the tests and once we fix the CPU pressure on the cluster, we can drop this change.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 21, 2025
@openshift-ci-robot
Copy link

@bitoku: No Jira issue with key OCPNODE-60643 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

What type of PR is this?

/kind flake

What this PR does / why we need it:

context: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1755784753878089?thread_ts=1755692105.699389&cid=C01CQA76KMX

We're pretty sure that the flakiness is caused by CPU pressure on the cluster, but it'll take some time to decide what to do (e.g. increase node sizes, increases the number of nodes, or reducing the parallelism).

This is a temporary measure to deflake the tests and once we fix the CPU pressure on the cluster, we can drop this change.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Aug 21, 2025
@openshift-ci-robot
Copy link

@bitoku: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bitoku bitoku changed the title OCPNODE-59735, OCPNODE-60643: UPSTREAM: <carry>: temporary measure to deflake flaky tests OCPBUGS-59735, OCPBUGS-60643: UPSTREAM: <carry>: temporary measure to deflake flaky tests Aug 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2025
@openshift-ci-robot
Copy link

@bitoku: This pull request references Jira Issue OCPBUGS-59735, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-60643, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind flake

What this PR does / why we need it:

context: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1755784753878089?thread_ts=1755692105.699389&cid=C01CQA76KMX

We're pretty sure that the flakiness is caused by CPU pressure on the cluster, but it'll take some time to decide what to do (e.g. increase node sizes, increases the number of nodes, or reducing the parallelism).

This is a temporary measure to deflake the tests and once we fix the CPU pressure on the cluster, we can drop this change.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and jerpeter1 August 21, 2025 14:27
@bitoku
Copy link
Author

bitoku commented Aug 21, 2025

/jira refresh

@openshift-ci-robot
Copy link

@bitoku: This pull request references Jira Issue OCPBUGS-59735, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-60643, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bitoku
Copy link
Author

bitoku commented Aug 21, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2025
@openshift-ci-robot
Copy link

@bitoku: This pull request references Jira Issue OCPBUGS-59735, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-60643, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bitoku
Copy link
Author

bitoku commented Aug 21, 2025

/retest-required

@haircommander
Copy link
Member

/cc @bertinatto @jacobsee
/lgtm

@bitoku when this merges can you open a bug to track reverting it? I think it can be marked as 4.20 blocker for now

@openshift-ci openshift-ci bot requested review from bertinatto and jacobsee August 21, 2025 17:05
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
Copy link

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bitoku, haircommander
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 21, 2025

@bitoku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial bb58f5b link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp bb58f5b link true /test e2e-gcp
ci/prow/okd-scos-e2e-aws-ovn bb58f5b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift bb58f5b link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-agnostic-ovn-cmd bb58f5b link false /test e2e-agnostic-ovn-cmd
ci/prow/k8s-e2e-conformance-aws bb58f5b link true /test k8s-e2e-conformance-aws
ci/prow/e2e-aws-ovn-techpreview-serial bb58f5b link false /test e2e-aws-ovn-techpreview-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

This should go to upstream first, and once it's merged there, we can backport to o/k with the PR number prefixed.

There are cases where flakes won't happen in upstream, but for those cases we should identify the reason and work with upstream to come up with a fix. Here is an example of a fix for a flake that was only happening in OpenShift CI, but we identified the root cause, worked with upstream, and came up with a fix that was later backported to o/k: kubernetes#132502

Feel free to use a PR against o/k to develop a fix, but once you are confident with the patch, work with upstream to get it merged there, and then backport it to o/k.

Please don't merge temporary <carry> patches in o/k, the rebase process is already difficult, this only makes things worse.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2025
@bitoku
Copy link
Author

bitoku commented Aug 25, 2025

@bertinatto
what makes it difficult is this is mere CPU resource problem, not race condition or timing problem. The test code itself is totally fine.
@haircommander what do you think? will we try raising a PR in upstream?

@bitoku
Copy link
Author

bitoku commented Aug 25, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview 10

Copy link

openshift-ci bot commented Aug 25, 2025

@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2f97c510-81b3-11f0-8120-9979455fe8f1-0

@bitoku
Copy link
Author

bitoku commented Aug 26, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview 10

Copy link

openshift-ci bot commented Aug 26, 2025

@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e447e180-8261-11f0-9a5d-4a95e26fd069-0

@bitoku
Copy link
Author

bitoku commented Aug 27, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn 10

Copy link

openshift-ci bot commented Aug 27, 2025

@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b5e61d50-834e-11f0-8d78-f7d830590706-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants