-
Notifications
You must be signed in to change notification settings - Fork 125
OCPBUGS-59735, OCPBUGS-60643: UPSTREAM: <carry>: temporary measure to deflake flaky tests #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…U pressure Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@bitoku: No Jira issue with key OCPNODE-59735 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bitoku: No Jira issue with key OCPNODE-60643 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bitoku: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@bitoku: This pull request references Jira Issue OCPBUGS-59735, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-60643, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@bitoku: This pull request references Jira Issue OCPBUGS-59735, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-60643, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@bitoku: This pull request references Jira Issue OCPBUGS-59735, which is valid. 3 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-60643, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
/cc @bertinatto @jacobsee @bitoku when this merges can you open a bug to track reverting it? I think it can be marked as 4.20 blocker for now |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bitoku, haircommander The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bitoku: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
This should go to upstream first, and once it's merged there, we can backport to o/k with the PR number prefixed.
There are cases where flakes won't happen in upstream, but for those cases we should identify the reason and work with upstream to come up with a fix. Here is an example of a fix for a flake that was only happening in OpenShift CI, but we identified the root cause, worked with upstream, and came up with a fix that was later backported to o/k: kubernetes#132502
Feel free to use a PR against o/k to develop a fix, but once you are confident with the patch, work with upstream to get it merged there, and then backport it to o/k.
Please don't merge temporary <carry>
patches in o/k, the rebase process is already difficult, this only makes things worse.
@bertinatto |
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview 10 |
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2f97c510-81b3-11f0-8120-9979455fe8f1-0 |
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview 10 |
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e447e180-8261-11f0-9a5d-4a95e26fd069-0 |
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn 10 |
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b5e61d50-834e-11f0-8d78-f7d830590706-0 |
What type of PR is this?
/kind flake
What this PR does / why we need it:
context: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1755784753878089?thread_ts=1755692105.699389&cid=C01CQA76KMX
We're pretty sure that the flakiness is caused by CPU pressure on the cluster, but it'll take some time to decide what to do (e.g. increase node sizes, increases the number of nodes, or reducing the parallelism).
This is a temporary measure to deflake the tests and once we fix the CPU pressure on the cluster, we can drop this change.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: