OCPBUGS-60851: UPSTREAM: <carry>: Exclude certain images from mirror list #2424
Conversation
`k8s-tests-ext images` returns the list of images we should mirror to be able to run tests. However, starting with d5b8cb3, we started returning invalid.registry.k8s.io images, which are intentionally not working images. These should be excluded from the list returned to callers.
openshift-ci-robot
added
backports/unvalidated-commits
|
@stbenjam: This pull request references Jira Issue OCPBUGS-60851, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-upgrade-ovn-ipv6 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a2e0feb0-81ea-11f0-9c5a-ea8dae931091-0 |
|
/test e2e-metal-ipi-upgrade-ovn-ipv6 |
|
@stbenjam: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-metal-ipi-ovn-ipv6 |
| continue imageLoop | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not 100% sure we should do this here. In my mind, the images command isn't to be used exclusively for image mirroring. The invalid image is in fact used by tests, it just doesn't exist.
I feel like we should stick to the output of GetE2EImage() and filter this out somewhere else. I don't have strong feeling, though.
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-tests-ext imagesreturns the list of images we should mirror to be able to run tests. However, starting with d5b8cb3, we started returning invalid.registry.k8s.io images, which are intentionally not working images. These should be excluded from the list returned to callers.