Skip to content

Conversation

spadgett
Copy link
Member

Preserve newlines in service instance status messages on the overview
and the provisioned service page. Truncate long message when displayed
in a tooltip.

See #2217

screen shot 2017-10-30 at 3 44 27 pm

screen shot 2017-10-30 at 4 11 12 pm

screen shot 2017-10-30 at 3 46 30 pm

@spadgett spadgett requested a review from rhamilto October 30, 2017 20:13
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2017
@spadgett
Copy link
Member Author

/kind bug

See also openshift/origin-web-catalog#542

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 30, 2017
@spadgett spadgett force-pushed the format-instance-status-messages branch from 7e9507e to b8ac5a0 Compare October 30, 2017 20:31
@spadgett
Copy link
Member Author

Fixed dist

@rhamilto ok to lgtm?

@spadgett
Copy link
Member Author

Adding lgtm label since changes are approved

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2017
Preserve newlines in service instance status messages on the overview
and the provisioned service page. Truncate long message when displayed
in a tooltip.
@spadgett spadgett force-pushed the format-instance-status-messages branch from b8ac5a0 to bd6c36c Compare October 30, 2017 23:10
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2017
@spadgett
Copy link
Member Author

Rebuilt dist only

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 0beaf62 into openshift:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants