Skip to content

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Oct 31, 2017

When editing DC environment variables the action links are following:
current-env

But the DC's Environment tab actions links are:
old-env

To be consistent (eg BC editor and BC Environment tab) the action links wording in the DC env tab should be:
new-env

@spadgett PTAL

@jhadvig jhadvig requested a review from spadgett October 31, 2017 09:59
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2017
@spadgett
Copy link
Member

spadgett commented Oct 31, 2017

@jhadvig We want to change the other pages to use the new wording. We've purposely changed how we worded it in the new designs.

@spadgett
Copy link
Member

Let's change these instances to use the wording from edit-environment-variables

app/views/directives/deploy-image.html
171:            add-row-with-selectors-link="Add Environment Variable Using a Config Map or Secret"></key-value-editor>

app/views/edit/deployment-config.html
75:                          add-row-with-selectors-link="Add Environment Variable Using a Config Map or Secret"></key-value-editor>
360:                      add-row-with-selectors-link="Add Environment Variable Using a Config Map or Secret"></key-value-editor>

app/views/directives/edit-lifecycle-hook.html
61:            add-row-with-selectors-link="Add Environment Variable Using a Config Map or Secret"

app/views/create/fromimage.html
287:                                add-row-with-selectors-link="Add Environment Variable Using a Config Map or Secret"></key-value-editor>

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2017
@jhadvig
Copy link
Member Author

jhadvig commented Oct 31, 2017

@spadgett comments addressed

@spadgett
Copy link
Member

Thanks @jhadvig

/kind bug
/lgtm

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Oct 31, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 2e5d697 into openshift:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants