Fix problems with env valueFrom for DC hooks #2461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
kind/bug
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
* Avoid adding an `undefined` element to value from array depending on the order that config maps and secrets load * Fix typo passing config maps to edit-lifecycle hooks * Show valueFrom values for hooks when viewing the deployment config Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1509842 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1509819
spadgett
force-pushed
the
value-from-hook
branch
from
7561b3a to
59edbeb
Compare
spadgett
commented
Nov 6, 2017
| @@ -123,7 +123,9 @@ angular.module("openshiftConsole") | |||
|
|
|||
| $scope.valueFromObjects = []; | |||
| $scope.$watchGroup(['availableSecrets', 'availableConfigMaps'], function() { | |||
| $scope.valueFromObjects = ($scope.availableSecrets || []).concat($scope.availableConfigMaps); | |||
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
jwforres
approved these changes
Nov 6, 2017
|
/lgtm |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefinedelement to value from array depending on theorder that config maps and secrets load
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1509842
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1509819
Fixes #2460
/kind bug
/assign @jwforres