Skip to content

UPSTREAM: 48709: glusterfs: retry without auto_unmount only when it's not supported #15199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2017
Merged

UPSTREAM: 48709: glusterfs: retry without auto_unmount only when it's not supported #15199

merged 3 commits into from
Sep 11, 2017

Conversation

jsafrane
Copy link
Contributor

This reduces time that OpenShift waits for gluster timeouts to one half (!) - it does not blindly try twice.

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1466249

@jsafrane
Copy link
Contributor Author

[test]

@jsafrane
Copy link
Contributor Author

[test]

flake: #11561

@jsafrane
Copy link
Contributor Author

[test]

@jsafrane jsafrane force-pushed the gluster-auto-unmount branch from de90853 to ff4399b Compare July 19, 2017 08:03
@jsafrane
Copy link
Contributor Author

[test]
flake: #15324

1 similar comment
@jsafrane
Copy link
Contributor Author

[test]
flake: #15324

@jsafrane
Copy link
Contributor Author

[test]
flake: #14897

@jsafrane jsafrane force-pushed the gluster-auto-unmount branch from ff4399b to b095871 Compare July 21, 2017 09:05
@jsafrane
Copy link
Contributor Author

Added kubernetes/kubernetes#49127 to further shorten gluster timeouts.

@openshift-merge-robot openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 24, 2017
@jsafrane
Copy link
Contributor Author

Added kubernetes/kubernetes#49475

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 398697d

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3474/) (Base Commit: 970dc61) (PR Branch Commit: 398697d)

@eparis
Copy link
Member

eparis commented Jul 25, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 25, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 4

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 398697d

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2017
@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2017
@childsb
Copy link
Contributor

childsb commented Sep 7, 2017 •
edited
Loading

/approve no-issue

@childsb
Copy link
Contributor

childsb commented Sep 7, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, jsafrane

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@0xmichalis
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor Author

/retest

@0xmichalis
Copy link
Contributor

flake was #16167

Please link to existing failures or open issues for missing ones

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 36bd807 into openshift:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@childsb childsb

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jsafrane @openshift-bot @eparis @childsb @openshift-merge-robot @0xmichalis @openshift-ci-robot