Skip to content

Conversation

juanvallejo
Copy link
Contributor

@openshift-merge-robot openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 27, 2017
@bparees bparees removed their assignment Jul 27, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@liggitt
Copy link
Contributor

liggitt commented Jul 28, 2017

/lgtm
/approve no-issue

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2017
@liggitt
Copy link
Contributor

liggitt commented Jul 28, 2017

[WARNING] !!! gofmt needs to be run on the following files: 
./pkg/cmd/admin/node/listpods.go
[FATAL] Try running 'gofmt -s -d [path]'
[FATAL] Or autocorrect with 'hack/verify-gofmt.sh | xargs -n 1 gofmt -s -w'

@joelsmith
Copy link
Contributor

/test extended_conformance_install_update
/test verify

@joelsmith
Copy link
Contributor

So this missed getting in for 3.6 because of a missing gofmt run on the changed code?

@liggitt
Copy link
Contributor

liggitt commented Aug 1, 2017

yes, and is still needed

@juanvallejo juanvallejo force-pushed the jvallejo/backport-15411 branch from 473623d to 44842cd Compare August 1, 2017 14:34
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2017
@juanvallejo
Copy link
Contributor Author

@liggitt wondering if you could tag once more, thanks

@liggitt
Copy link
Contributor

liggitt commented Aug 1, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, liggitt

Associated issue requirement bypassed by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fabianofranz
Copy link
Member

Good to merge.

@jupierce jupierce merged commit fbbe981 into openshift:release-3.6 Aug 1, 2017
@juanvallejo juanvallejo deleted the jvallejo/backport-15411 branch August 1, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants