Skip to content

UPSTREAM: 49992: Correctly handle empty watch event cache #15614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2017
Merged

UPSTREAM: 49992: Correctly handle empty watch event cache #15614

merged 1 commit into from
Aug 11, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 2, 2017

No description provided.

@openshift-merge-robot openshift-merge-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 2, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2017
@liggitt liggitt added this to the 3.7.0 milestone Aug 2, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 3, 2017

/retest

@stevekuznetsov
Copy link
Contributor

/test extended_conformance_install_update

2 similar comments
@stevekuznetsov
Copy link
Contributor

/test extended_conformance_install_update

@stevekuznetsov
Copy link
Contributor

/test extended_conformance_install_update

@liggitt
Copy link
Contributor Author

liggitt commented Aug 8, 2017

upstream is merged

@liggitt liggitt added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 8, 2017

/test extended_templates

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@0xmichalis
Copy link
Contributor

/retest

2 similar comments
@0xmichalis
Copy link
Contributor

/retest

@0xmichalis
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@stevekuznetsov
Copy link
Contributor

Only eight re-tests later ... woo!!!!

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@liggitt
Copy link
Contributor Author

liggitt commented Aug 10, 2017

/retest

@0xmichalis
Copy link
Contributor

yum

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15716, 15614)

@openshift-merge-robot openshift-merge-robot merged commit 3178c5c into openshift:master Aug 11, 2017
@liggitt liggitt deleted the watch-cache branch August 24, 2017 03:58
@liggitt liggitt mentioned this pull request Aug 24, 2017
Merged
openshift-merge-robot added a commit that referenced this pull request Aug 24, 2017
@openshift-merge-robot
Merge pull request #15616 from liggitt/watch-cache-3.6.1
60e01e9 
Automatic merge from submit-queue

3.6.x: UPSTREAM: 49992: Correctly handle empty watch event cache

pick of #15614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @openshift-merge-robot @stevekuznetsov @0xmichalis @openshift-bot @deads2k