Skip to content

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Sep 13, 2017

Backporting #16324 to the 3.6 branch

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2017
@danwinship
Copy link
Contributor

/unassign
/assign @mfojtik

@bparees
Copy link
Contributor

bparees commented Sep 13, 2017

/lgtm

but we need to make sure @dmage re-enables these tests when he backports his fix (#16322)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, joelsmith

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2017
@0xmichalis 0xmichalis removed their assignment Sep 13, 2017
@joelsmith
Copy link
Contributor Author

/retest

2 similar comments
@soltysh
Copy link
Contributor

soltysh commented Sep 14, 2017

/retest

@0xmichalis
Copy link
Contributor

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit b216da3 into openshift:release-3.6 Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/blocks-others size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants