Fix duplicate timeout directive #17030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When haproxy.router.openshift.io/timeout is set the template is setting the timeout directive twice. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1503637
openshift-ci-robot
added
the
size/XS
|
PTAL @openshift/networking |
pravisankar
approved these changes
Oct 24, 2017
|
/lgtm |
knobunc
requested changes
Oct 26, 2017
| @@ -346,10 +346,6 @@ backend be_secure:{{$cfgIdx}} | |||
| timeout server {{$value}} | |||
| {{- end }} {{/* end balance algorithm setting. */}} | |||
There was a problem hiding this comment.
Is the comment {{/* end balance algorithm setting. */}} actually correct?
I think I'd just lose it.
|
/test |
openshift-merge-robot
removed
the
lgtm
openshift-merge-robot
added
the
approved
|
/approve Thanks @imcsk8 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imcsk8, knobunc, pravisankar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
|
/retest |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When haproxy.router.openshift.io/timeout is set the template
is setting the timeout directive twice.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1503637