Skip to content

verify-signature: fixed (in)secure transport #17202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2017
Merged

verify-signature: fixed (in)secure transport #17202

merged 2 commits into from
Nov 7, 2017

Conversation

miminar
Copy link

@miminar miminar commented Nov 6, 2017

And reenabled image signature workflow extended test.

Resolves #15809

Michal Minář added 2 commits November 6, 2017 19:25
verify-signature: fixed insecure fall-back
436d0fe 
Ignore not trusted CA with connected to secured registry.

Signed-off-by: Michal Minář <miminar@redhat.com>
extended: reenabled image signature workflow test
262b8ba 
Signed-off-by: Michal Minář <miminar@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2017
@miminar
Copy link
Author

miminar commented Nov 6, 2017 •
edited
Loading

/assign @mfojtik
/cc @legionus
/cc @bparees

@openshift-ci-robot
Copy link

@miminar: GitHub didn't allow me to request PR reviews from the following users: agladkov.

Note that only openshift members can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @mfojtik
/cc @agladkov
/cc @bparees

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miminar miminar unassigned knobunc and dcbw Nov 6, 2017
@miminar
Copy link
Author

miminar commented Nov 6, 2017

/test
/test extended_image_registry

@bparees bparees added the kind/bug Categorizes issue or PR as related to a bug. label Nov 6, 2017
@bparees
Copy link
Contributor

bparees commented Nov 6, 2017

registry test passed.

/lgtm

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, miminar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2017
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 985a79b into openshift:master Nov 7, 2017
@miminar miminar deleted the signature-workflow-reenabled-15809 branch February 22, 2018 15:48
This was referenced Apr 9, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

Assignees

@mfojtik mfojtik

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@miminar @openshift-ci-robot @bparees @openshift-merge-robot @openshift-bot @mfojtik @knobunc @dcbw