Revert "UPSTREAM: 53916: update .dockercfg data to config.json format #18062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son format" This reverts commit 8363697.
openshift-ci-robot
added
the
size/S
openshift-merge-robot
added
the
vendor-update
This reverts commit 5304de7.
|
Fixes #17197 |
This was referenced Jan 11, 2018
Creating secret with
oc secret new-dockercfg ... creates secret in a new docker config format
#17197
Closed
|
Fixes #18059 |
juanvallejo
approved these changes
Jan 12, 2018
|
/lgtm |
|
Fixes #18072 |
|
cc @mfojtik for approval |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, mfojtik, soltysh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
This was referenced Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses problem described in https://bugzilla.redhat.com/show_bug.cgi?id=1531511 and https://bugzilla.redhat.com/show_bug.cgi?id=1476330
This reverts commit 8363697, to make it compatible with
kubectl create secret docker-registryfrom k8s 1.7.@juanvallejo ptal