Skip to content

Conversation

tsmetana
Copy link
Member

This is a backport of the upstream fix for Cinder volumes not being detached from a removed/failed node.

Related Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1523142

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 17, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2018
@tsmetana
Copy link
Member Author

/test unit

@gnufied
Copy link
Member

gnufied commented Jan 23, 2018

I reviewed this patch upstream in detail as well. Looks good to me.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2018
@tsmetana
Copy link
Member Author

flake #17882

@childsb
Copy link
Contributor

childsb commented Feb 1, 2018

/approve
@smarterclayton can you give final approve so this will merge?

@mfojtik
Copy link
Contributor

mfojtik commented Feb 2, 2018

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Feb 2, 2018

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, gnufied, mfojtik, tsmetana

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2018
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 413056b into openshift:master Feb 2, 2018
@tsmetana tsmetana deleted the fix-cinder-detach branch October 9, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants