UPSTREAM: 58955: pkg: kubelet: do not assume anything about images names #18340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-merge-robot
added
the
vendor-update
|
LGTM |
|
need a 3.8 pick since 3.8 masters run 3.8 nodes. |
|
@derekwaynecarr I also verified the positive case in which the image does exist in the configured, non-docker, registry and the container pulls from the configured registry and runs successfully. |
|
my old friend, flake #17556 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, sjenning The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 18225, 18351, 18331, 18340, 18326). |
openshift-merge-robot
added a commit
that referenced
this pull request
Feb 15, 2018
Automatic merge from submit-queue (batch tested with PRs 18624, 18605). Revert "Admission plugin: openshift.io/ImageQualify" This reverts commit 8bc3e07. #18020 Render unneeded by upstream kubernetes/kubernetes#58955 and Origin pick #18340 Will live on forever in git history if we find a use case for it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes/kubernetes#58955
removes the need for #18020
see history:
kubernetes/kubernetes#51751
kubernetes/kubernetes#52110
kubernetes/kubernetes#53161
@liggitt @derekwaynecarr @frobware @mrunalp @runcom