Skip to content

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Feb 5, 2018

Also fix error handling in operation hooks.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540039

Also fix error handling in operation hooks.
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 5, 2018
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 5, 2018
@gnufied
Copy link
Member Author

gnufied commented Feb 5, 2018

verified that the PR brings back the metrics:

storage_operation_errors_total{operation_name="volume_attach",volume_plugin="kubernetes.io/aws-ebs"} 1

@gnufied
Copy link
Member Author

gnufied commented Feb 5, 2018

/assign @jsafrane

@gnufied
Copy link
Member Author

gnufied commented Feb 5, 2018

/retest

@childsb
Copy link
Contributor

childsb commented Feb 5, 2018

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2018
@childsb
Copy link
Contributor

childsb commented Feb 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, gnufied

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@gnufied
Copy link
Member Author

gnufied commented Feb 5, 2018

/test extended_conformance_install

1 similar comment
@gnufied
Copy link
Member Author

gnufied commented Feb 6, 2018

/test extended_conformance_install

@jsafrane
Copy link
Contributor

jsafrane commented Feb 6, 2018

/retest

@gnufied
Copy link
Member Author

gnufied commented Feb 6, 2018

test gcp is failing on:

+ ../../bin/ansible.sh ansible-playbook -e openshift_test_repo=https://storage.googleapis.com/origin-ci-test/pr-logs/pull/18442/test_pull_request_origin_extended_conformance_gce/15652/artifacts/rpms playbooks/gcp/openshift-cluster/launch.yml
Activated service account credentials for: [jenkins-ci-provisioner@openshift-gce-devel.iam.gserviceaccount.com]
 [WARNING]: Could not match supplied host pattern, ignoring: all
 [WARNING]: provided hosts list is empty, only localhost is available

Does not look like remotely related to this PR.

@gnufied
Copy link
Member Author

gnufied commented Feb 6, 2018

/test gcp

@gnufied
Copy link
Member Author

gnufied commented Feb 6, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit c49e64b into openshift:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants